Store PeerKind in known-peers file

[mattsse]

Describe the feature

currently on shutdown we store just the enodes:

reth/crates/node/builder/src/builder/mod.rs

Line 731 in b36fc95

match network.write_peers_to_file(peers_file.as_path()) {

thereby stripping away context, such as whether the peer is trusted or not.

TODO

• introduce a new datastructure that also groups them by PeerKind in the file
• update read and write functions

reading:

reth/crates/net/network-types/src/peers/config.rs

Lines 284 to 298 in b36fc95

	/// Read from file nodes available at launch. Ignored if None.
	pub fn with_basic_nodes_from_file(
	self,
	optional_file: Option<impl AsRef<Path>>,
	) -> Result<Self, io::Error> {
	let Some(file_path) = optional_file else { return Ok(self) };
	let reader = match std::fs::File::open(file_path.as_ref()) {
	Ok(file) => io::BufReader::new(file),
	Err(e) if e.kind() == ErrorKind::NotFound => return Ok(self),
	Err(e) => Err(e)?,
	};
	info!(target: "net::peers", file = %file_path.as_ref().display(), "Loading saved peers");
	let nodes: HashSet<NodeRecord> = serde_json::from_reader(reader)?;
	Ok(self.with_basic_nodes(nodes))
	}

writing

reth/crates/node/builder/src/builder/mod.rs

Line 731 in b36fc95

match network.write_peers_to_file(peers_file.as_path()) {

this change should be backwards compat so we should also try this format when reading:

reth/crates/net/network-types/src/peers/config.rs

Line 296 in b36fc95

let nodes: HashSet<NodeRecord> = serde_json::from_reader(reader)?;

Additional context

No response

[Soubhik-10]

Can I take this?

[mattsse]

assigned, ty

[nadtech-hub]

✋