Some Relay Client Errors Reporting as Info

[estein9825]

Expected vs actual behavior

After installing a relay client into a cluster, I got a TLS error. I had expected the error to be reported in the log as an "error" level. But instead it was "info"

Sample error:

{"level":"info","ts":"2023-02-10T17:07:24.326Z","caller":"tunnel/client.go:460","msg":"Relay Agent.Client.paralus-core-relay-agent::action backoff sleep: 26.373942655s  address: 6f881749-fa78-4a50-b6a7-f41ab57273a0.core-connector.paralus.iherbpreprod.net:443  "}
{"level":"info","ts":"2023-02-10T17:07:28.308Z","caller":"tunnel/client.go:416","msg":"Relay Agent.Client.paralus-core-relay-agent::dial failed network: tcp  addr: 6f881749-fa78-4a50-b6a7-f41ab57273a0.core-connector.paralus.iherbpreprod.net:443  err: x509: certificate has expired or is not yet valid: current time 2023-02-10T17:07:28Z is after 2020-09-18T12:00:00Z  "}

Steps to reproduce the bug

Not sure, given it's a TLS error that is sent by paralus

Are you using the latest version of the project?

You can check your version by running helm ls|grep '^<deployment-name>' or using pctl, pctl version, and provide the output.

VERSION: 0.1.0
BUILD: 0.1.0
BUILD-TIME: 1656329967
ARCH: darwin/amd64

What is your environment setup? Please tell us your cloud provider, operating system, and include the output of kubectl version --output=yaml and helm version. Any other information that you have, eg. logs and custom values, is highly appreciated!

Kubectl

clientVersion:
  buildDate: "2022-08-23T17:44:59Z"
  compiler: gc
  gitCommit: a866cbe2e5bbaa01cfd5e969aa3e033f3282a8a2
  gitTreeState: clean
  gitVersion: v1.25.0
  goVersion: go1.19
  major: "1"
  minor: "25"
  platform: darwin/amd64
kustomizeVersion: v4.5.7
serverVersion:
  buildDate: "2022-11-29T18:41:42Z"
  compiler: gc
  gitCommit: 52e500d139bdef42fbc4540c357f0565c7867a81
  gitTreeState: clean
  gitVersion: v1.22.16-eks-ffeb93d
  goVersion: go1.16.15
  major: "1"
  minor: 22+
  platform: linux/amd64

Helm

version.BuildInfo{Version:"v3.10.3", GitCommit:"835b7334cfe2e5e27870ab3ed4135f136eecc704", GitTreeState:"clean", GoVersion:"go1.19.4"}

(optional) If you have ideas on why the bug happens or how it can be solved, please provide it here

Catch certain client errors and report them as error and not info

• [X ] I've described the bug, included steps to reproduce it, and included my environment setup with all customizations.
• [ X] I'm using the latest version of the project.

[akshay196]

Good catch.
It seems this is related to relay agent.

[akshay196]

Quick fix: In case of agent dial out connection failure, print the error log (instead of info). Specifically need to change this line: https://github.com/paralus/relay/blob/main/pkg/tunnel/client.go#L416

[theluckiesthuman]

@akshay196 Please assign this to me.

[akshay196]

@theluckiesthuman Done.