Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paranext-core/extensions vite build failure if there's an empty folder in extensions folder #233

Closed
tjcouch-sil opened this issue Jun 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Jun 9, 2023

If the extensions/lib folder has an extra folder in it with no contents (or not many contents, particularly a manifest.json file), the Vite build will crash, and it is quite difficult to discover this issue.

This can easily occur if you make a branch where you are making a new extension, then you commit and switch off that branch. Since git doesn't care about directories, that empty extension directory will be left over.

@tjcouch-sil tjcouch-sil converted this from a draft issue Jun 9, 2023
@tjcouch-sil tjcouch-sil moved this to 📋Product Backlog in Paranext Jun 9, 2023
@tjcouch-sil tjcouch-sil added the bug Something isn't working label Oct 3, 2023
@katherinejensen00
Copy link
Contributor

Check to see if this error still occurs in Webpack

@katherinejensen00 katherinejensen00 moved this from Open to Product Backlog in Paranext Oct 23, 2023
@GlennPruitt GlennPruitt added this to the 2023-12 Q4 Maintenance milestone Nov 14, 2023
@tjcouch-sil
Copy link
Member Author

This issue occurs on this line and is fixed in #486

@tjcouch-sil tjcouch-sil self-assigned this Jan 3, 2024
@tjcouch-sil tjcouch-sil moved this from 🎬 Product Backlog to 🏗 In progress in Paranext Jan 3, 2024
@tjcouch-sil tjcouch-sil moved this from 🏗 In progress to 👀 In review in Paranext Jan 3, 2024
@tjcouch-sil tjcouch-sil moved this from 👀 In review to ✅ Done in Paranext Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants