Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshCubatureNodes assumes simplices are affine #26

Open
tcew opened this issue Apr 20, 2020 · 2 comments
Open

meshCubatureNodes assumes simplices are affine #26

tcew opened this issue Apr 20, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@tcew
Copy link
Contributor

tcew commented Apr 20, 2020

The meshCubatureNodesTri2D and Tet3D functions use linear maps to construct the physical cubature node coordinates.

If the WB physical nodes and WB2cubature interpolation matrix cubI are already constructed then building the physical cubature nodes is trivial

cubx = cubI*x; in matlab speak.

@noelchalmers noelchalmers added the good first issue Good for newcomers label Apr 20, 2020
@noelchalmers
Copy link
Member

This is probably part of the larger 'support curved simplex elements' project. There are several places right now, most notably the geo factors, where we're assuming affine elements.

@tcew
Copy link
Contributor Author

tcew commented Apr 20, 2020

There are decisions to be made about how to implement curvilinear simplices.

Do we use the same array for geofacs for both affine and non-affine elements with an inevitable offsets array.

Do we sort elements into curved and noncurved groups then just need a single offset.

Do we create separate meshes.

Do we intend to support curvilinear elements of differing degree in their physical map construction ( for which affine and isoparametric would just be two instances )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants