Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textile autolinks do not work anymore #4

Open
villem opened this issue Sep 4, 2009 · 5 comments
Open

textile autolinks do not work anymore #4

villem opened this issue Sep 4, 2009 · 5 comments

Comments

@villem
Copy link

villem commented Sep 4, 2009

This probably maraoku related regression. With older releases the http://url and [email protected] were automatically made proper html tags.

We have wiki starting from 0.7 releases so we cannot easily switch to different markup language.

@distler
Copy link
Collaborator

distler commented Sep 4, 2009

Autolinking was disabled in Revision 166 because the autolinking code sucked.

Anyone who wants to try fixing the code, so that it isn't as ridiculously slow, and is guaranteed not to produce ill-formed XHTML output, is welcome to do so. If they succeed, I'll re-enable auto-linking.

@villem
Copy link
Author

villem commented Sep 14, 2009

Ok. Thanks for this pointer. We might enable this in our wiki. We do not use any advanced new features that has come since 0.7.

@villem
Copy link
Author

villem commented Sep 14, 2009

You can close this one. It seems that comment and close is not working for me.

@distler
Copy link
Collaborator

distler commented Sep 14, 2009

Only Matthias or I can close issues.

As you have discovered, it's easy-enough to re-enable Autolinking-support. If this really does not cause any problems in the Textile formatter (it definitely causes problems with the Markdown formatter, and with the "advanced" new features), we might consider re-enabling it for Textile only.

Therefore, I think I will keep this issue open, as a reminder.

@villem
Copy link
Author

villem commented Sep 15, 2009

I tried to re-enable the autolink code e.g just revert the commit http://github.com/parasew/instiki/commit/3a3cfeaa9b43a15e7cfbb90113465ab6f258e968. But this did not enable autolinking. Maybe I need to revert more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants