Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't swallow responses on errors #24

Open
sakulstra opened this issue Feb 11, 2021 · 0 comments
Open

don't swallow responses on errors #24

sakulstra opened this issue Feb 11, 2021 · 0 comments

Comments

@sakulstra
Copy link
Contributor

sakulstra commented Feb 11, 2021

I tried integrating with paraswap SDK, but felt like debugging is relatively hard.

When the api responds with an error code the complete response is swallowed making debugging kinda hellish.
I'd suggest do serve the response alongside the error instead of throwing it away as in the case of slippage errors like here: https://apiv2.paraswap.io/v2/prices/?from=0x7fc66500c84a76ad7e9c93437bfc5ac33e2ddae9&to=0x6b175474e89094c44da98b954eedeac495271d0f&amount=30000000000000000000000&side=BUY it might make sense to display some sort of feedback in the ui.

bogdoslavik pushed a commit to dystopia-exchange/paraswap-sdk that referenced this issue May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant