Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for negated Ignores Globs #166

Open
arciisine opened this issue Feb 7, 2024 · 0 comments
Open

Support for negated Ignores Globs #166

arciisine opened this issue Feb 7, 2024 · 0 comments

Comments

@arciisine
Copy link

Looking back at the PR (#106), support for ignore globs was added about a year ago. The glob implementation supports negation on a per rule basis, but it appears when checking if something is ignored or not, a negated glob is not treated as an escape hatch.

As far as I can tell, given the current pattern, negated globs have no impact as the logic for ignore resolution only cares if the match is positive.

https://github.com/parcel-bundler/watcher/blob/master/src/Watcher.cc#L224-L230

Ideally this would behave similar to .gitignore, so I could ignore node_modules/**, and then allow a specific folder underneath that with an exclusion.

@arciisine arciisine changed the title Support for Negated Ignores Globs Support for negated Ignores Globs Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant