Core refinery explodes the TTV outside the refiner

[Zonespace27]

Round ID: 103

Testmerges:

#469: 'ZASR(eforged): A Baystation12 port & modification' by Kapu1178 at commit be287e74fe
#730: 'Baystation airlock sounds' by Kapu1178 at commit 593adbbd87
#767: 'Adds a Vox Description' by Tokorizo at commit e59c5fc335
#780: 'A little something special for AIs.' by francinum at commit 59cdddb21e
#777: 'Shuttle smoothing improvements' by SabreML at commit 7dea130530
#792: 'Most likely not how this works, but, clothing fitting, less human sprites on less conventionally humanoid species' by ElorgRHG at commit 3984ff92de
#786: 'NSV Parallax Port' by Tokorizo at commit 7a847fff6c
#787: 'Gamuioda (Moth) head shape update: They actually look like bugs now, woah.' by Ebin-Halcyon at commit 6aa0b5beee
#782: 'Just straight up removes plumbing' by ElorgRHG at commit 550c99554e

Reproduction:

Core refinery explodes the TTV outside of the refinery, which leads to this

[SabreML]

Looking into this now. I reproduced it during the same round on the server but it's working fine on master, so it seems like it's testmerge related.

[SabreML]

This is caused by #469, specifically this part in the /obj/item/tank/atom_destruction() proc:

Pariah-Station/code/game/objects/items/tanks/tanks.dm

Lines 347 to 354 in be287e7

	log_atmos("[type] exploded with a power of [strength * mult] and a mix of ", air_contents)
	explosion(
	get_turf(loc),
	round(min(BOMBCAP_DVSTN_RADIUS, ((mult)*strength)*0.15)),
	round(min(BOMBCAP_HEAVY_RADIUS, ((mult)*strength)*0.35)),
	round(min(BOMBCAP_LIGHT_RADIUS, ((mult)*strength)*0.80)),
	round(min(BOMBCAP_FLASH_RADIUS, ((mult)*strength)*1.20)),
	)

Compared to the same section from master:

Pariah-Station/code/game/objects/items/tanks/tanks.dm

Lines 337 to 338 in a83d280

	log_atmos("[type] exploded with a power of [power] and a mix of ", air_contents)
	dyn_explosion(src, power, flash_range = 1.5, ignorecap = FALSE)

Pariah-Station/code/controllers/subsystem/explosions.dm

Lines 180 to 185 in a83d280

	/proc/dyn_explosion(turf/epicenter, power, flame_range = 0, flash_range = null, adminlog = TRUE, ignorecap = TRUE, silent = FALSE, smoke = TRUE, atom/explosion_cause = null)
	if(!power)
	return
	var/range = 0
	range = round((2 * power)**GLOB.DYN_EX_SCALE)
	explosion(epicenter, devastation_range = round(range * 0.25), heavy_impact_range = round(range * 0.5), light_impact_range = round(range), flame_range = flame_range*range, flash_range = flash_range*range, adminlog = adminlog, ignorecap = ignorecap, silent = silent, smoke = smoke, explosion_cause = explosion_cause)

---

The anomaly refinery blocks any internal explosions from getting out by registering the COMSIG_ATOM_INTERNAL_EXPLOSION signal and returning COMSIG_CANCEL_EXPLOSION. This means that the full explosion technically still happens, but it gets cancelled before it can actually damage anything.

Pariah-Station/code/controllers/subsystem/explosions.dm

Lines 239 to 246 in a83d280

	var/atom/location = isturf(origin) ? origin : origin.loc
	if(SEND_SIGNAL(origin, COMSIG_ATOM_EXPLODE, arguments) & COMSIG_CANCEL_EXPLOSION)
	return // Signals are incompatible with `arglist(...)` so we can't actually use that for these. Additionally,
	while(location)
	var/next_loc = location.loc
	if(SEND_SIGNAL(location, COMSIG_ATOM_INTERNAL_EXPLOSION, arguments) & COMSIG_CANCEL_EXPLOSION)
	return

Pariah-Station/code/modules/research/anomaly/anomaly_refinery.dm

Lines 41 to 43 in a83d280

	/obj/machinery/research/anomaly_refinery/Initialize(mapload)
	. = ..()
	RegisterSignal(src, COMSIG_ATOM_INTERNAL_EXPLOSION, .proc/check_test)

---

The actual explanation:
The bug is being caused by explosion() getting sent the turf rather than the gas tank as its origin argument. Because of this, COMSIG_ATOM_INTERNAL_EXPLOSION isn't sent to the anomaly refinery, and the explosion never gets blocked.
The bug can be fixed by changing the argument from get_turf(loc) back to src, but that might not be the correct solution:

		log_atmos("[type] exploded with a power of [strength * mult] and a mix of ", air_contents)
		explosion(
-			get_turf(loc),
+			src,
			round(min(BOMBCAP_DVSTN_RADIUS, ((mult)*strength)*0.15)),
			round(min(BOMBCAP_HEAVY_RADIUS, ((mult)*strength)*0.35)),
			round(min(BOMBCAP_LIGHT_RADIUS, ((mult)*strength)*0.80)),
			round(min(BOMBCAP_FLASH_RADIUS, ((mult)*strength)*1.20)),
		)