Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Workflows refactoring #163

Open
glemaitre opened this issue Nov 27, 2018 · 1 comment
Open

[RFC] Workflows refactoring #163

glemaitre opened this issue Nov 27, 2018 · 1 comment

Comments

@glemaitre
Copy link
Contributor

glemaitre commented Nov 27, 2018

The workflows should be derived from a metaclass to enforce having the parameter element_names.

I would like also to investigate:

  • If workflows should be derived from the scikit-learn Pipeline more generally.
  • The element of the workflow should have a tag _estimator_type to indicate which type they are. The integration with WorflowElementType would be eased.
@kegl kegl changed the title [RFC] Worflows refactoring [RFC] Workflows refactoring Nov 27, 2018
@kegl
Copy link
Contributor

kegl commented Nov 27, 2018

Good idea. As for deriving from Pipeline, why not. The simpler workflows could certainly be pipelined. I just don't think it could be done in general (e.g. drug spectra in which we have quite a bit of glue code between the steps. The flexible handling of CV folds is also something that makes it more general. Anyway, no reason not to investigate.

The WorflowElementType and the whole structure was introduced a bit prematurely. I thought we could syntactically support transfer learning by enforcing certain conventions. I'm less keen on this now, first there was no real demand for this, second, it's a bit dubious whether an element made for a certain problem can be reused in another. I would approach this from an AutoML point of view now. So your second bullet is a bit less important for me, I'd let the demand evolve a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants