Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LGTM.com error: Wrong number of arguments in a call #294

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Nov 25, 2021

  • Fix the actual error. Whether some arguments should be made optional (with a default value of None) can be left for later.
  • Clearly rampwf.score_types.detection.util.mask_detection_curve is not covered by tests.

Fixes #291.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft November 25, 2021 19:52
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #294 (3e5786b) into master (4c71c23) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         137      137           
  Lines        4748     4748           
=======================================
  Hits         3948     3948           
  Misses        800      800           
Impacted Files Coverage Δ
rampwf/score_types/detection/util.py 80.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c71c23...3e5786b. Read the comment docs.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review February 1, 2023 05:35
@DimitriPapadopoulos DimitriPapadopoulos closed this by deleting the head repository Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong number of arguments in a call
1 participant