Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: replace os.path with pathlib.Path #317

Open
rth opened this issue Sep 14, 2022 · 1 comment
Open

MAINT: replace os.path with pathlib.Path #317

rth opened this issue Sep 14, 2022 · 1 comment

Comments

@rth
Copy link
Collaborator

rth commented Sep 14, 2022

This package does a lot of path manipulations, and it would be nice to use pathlib.Path more. See https://treyhunner.com/2018/12/why-you-should-be-using-pathlib/ for motivation of using pathlib.

This is particularly useful in combination with typing #316 since path then would be of type Path instead of str. The code would also be much sorter (less of os.path.join everywhere) and more readable.

A potential maintenance task cc @SofianChay

@kegl
Copy link
Contributor

kegl commented Sep 16, 2022

I second it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants