fixed linting issues

paritytech · Sep 26, 2023 · fd4b55f · fd4b55f
1 parent da4b77e
commit fd4b55f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/src/github/comments.ts b/src/github/comments.ts
@@ -8,7 +8,7 @@ export class CommentsApi {
     public readonly pullData: { repo: string; owner: string; number: number },
   ) {}
 
-  async comment(message: string) {
+  async comment(message: string): Promise<void> {
     await this.api.rest.issues.createComment({
       ...this.pullData,
       body: message,

diff --git a/src/github/merger.ts b/src/github/merger.ts
@@ -8,15 +8,15 @@ export const ENABLE_AUTO_MERGE = `
 mutation($prId: ID!, $mergeMethod: PullRequestMergeMethod!) {
     enablePullRequestAutoMerge(input: {pullRequestId: $prId, mergeMethod: $mergeMethod}) {
         clientMutationId
-         }
+    }
 }`;
 
 // https://docs.github.com/en/graphql/reference/mutations#disablepullrequestautomerge
 export const DISABLE_AUTO_MERGE = `
 mutation($prId: ID!) {
     disablePullRequestAutoMerge(input: {pullRequestId: $prId}) {
         clientMutationId
-         }
+    }
 }`;
 
 export type MergeMethod = "SQUASH" | "MERGE" | "REBASE";
@@ -29,8 +29,8 @@ export class Merger {
     private readonly mergeMethod: PullRequestMergeMethod,
   ) {}
 
-  async enableAutoMerge() {
-    const mergeRequest = await this.gql<{
+  async enableAutoMerge(): Promise<void> {
+    await this.gql<{
       enablePullRequestAutoMerge: { clientMutationId: unknown };
     }>(ENABLE_AUTO_MERGE, {
       prId: this.nodeId,
@@ -39,8 +39,8 @@ export class Merger {
     this.logger.info("Succesfully enabled auto-merge");
   }
 
-  async disableAutoMerge() {
-    const mergeRequest = await this.gql<{
+  async disableAutoMerge(): Promise<void> {
+    await this.gql<{
       disablePullRequestAutoMerge: { clientMutationId: unknown };
     }>(DISABLE_AUTO_MERGE, {
       prId: this.nodeId,

diff --git a/src/index.ts b/src/index.ts
@@ -34,6 +34,7 @@ logger.info(`Received event of typer ${context.eventName}`);
 
 if (context.eventName !== "issue_comment") {
   throw new Error("Wrong event type");
+  // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
 } else if (!context.payload.issue?.pull_request) {
   throw new Error("Comment happened on an issue, not a PR");
 }

diff --git a/src/test/queries.test.ts b/src/test/queries.test.ts
@@ -1,4 +1,4 @@
-import { validate, PullRequestMergeMethod } from "@octokit/graphql-schema";
+import { validate } from "@octokit/graphql-schema";
 
 import { ENABLE_AUTO_MERGE, DISABLE_AUTO_MERGE } from "../github/merger";