Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

litep2p update breaks polkadot release v1.11.0 #4602

Open
2 tasks done
krisbitney opened this issue May 27, 2024 · 0 comments
Open
2 tasks done

litep2p update breaks polkadot release v1.11.0 #4602

krisbitney opened this issue May 27, 2024 · 0 comments
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@krisbitney
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

The issue seems to be that the version for litep2p points specifically to the master branch instead of the release version branch: https://github.com/paritytech/polkadot-sdk/blob/release-polkadot-v1.11.0/substrate/client/network/Cargo.toml#L62C1-L62C79

error[E0026]: variant `GetRecordSuccess` does not have a field named `record`
   --> /Users/kris/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/0bb6249/substrate/client/network/src/litep2p/discovery.rs:459:65
    |
459 |             Poll::Ready(Some(KademliaEvent::GetRecordSuccess { query_id, record })) => {
    |                                                                          ^^^^^^
    |                                                                          |
    |                                                                          variant `GetRecordSuccess` does not have this field
    |                                                                          help: a field with a similar name exists: `records`

For more information about this error, try `rustc --explain E0026`.
error: could not compile `sc-network` (lib) due to 1 previous error

Steps to reproduce

clear cache and build polkadot v1.11.0

@krisbitney krisbitney added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels May 27, 2024
@krisbitney krisbitney changed the title litep2p update breaks polkadot release v1.11.0 litep2p update breaks older polkadot releases May 27, 2024
@krisbitney krisbitney changed the title litep2p update breaks older polkadot releases litep2p update breaks polkadot release v1.11.0 May 27, 2024
bkchr pushed a commit that referenced this issue May 28, 2024
Litep2p version 0.5.0 backport to 1.11.0

Closes: #4602

---------

Signed-off-by: Alexandru Vasile <[email protected]>
girazoki added a commit to moondance-labs/tanssi that referenced this issue Jun 26, 2024
* Copy-in rococo runtime from paritytech/polkadot-sdk:v1.11.0

* Add rococo runtime to root Cargo.toml as package

* Update rococo-runtime Cargo.toml

* Update rococo-runtime-constants Cargo.toml

* Update Cargo.lock

* Rename copied-in rococo to mozart and point root Cargo.toml back to the original rococo and add mozart

* Add TODO around staging_xcm network reference still being to Rococo

* Patch Cargo.lock to pin litep2p to 0.3.0 (paritytech/polkadot-sdk#4602)

* Hoist all polkadot mozart-runtime-constants crates into workspace Cargo.toml. Have to rename them as you can't alias in sub-crate

* [wip] Hoist all polkadot mozart-runtime crates into workspace Cargo.toml. Have to rename them as you can't alias in sub-crate

* wip

* fix: Cargo.lock rebase error

* Update comment in Cargo.toml

* wip

* Apply toml-maid fixes

* Use workspace version of parity-scale-codec - Cargo.lock matches master and polkadot-sdk

* Add FIXME

* Apply cargo fmt changes

* Update mozart runtime use of hex-literal to point to workspace

* Apply zepter fix - add sp-keyring (keyring) and sp-trie to std in mozart

* Apply toml-maid fixes

* Apply toml-maid fixes

* Re-organize crates

* Remove .git suffix from crates

* Add crates for tanssi-relay-node

* Add Cargo.toml for tanssi-relay-node

* Add mozart/node to members

* Add empty file to mozart/node

* Update Cargo.lock

* Remove westend runtime references

* Replace rococo references with mozart

* Add tanssi-relay-node crate to workspace Cargo.toml

* Add rococo chain spec .json for now

* Add Mozart chain spec

* Add Mozart benchmarking

* Add fake runtime api to tanssi-relay-node

* Add grandpa support  to tanssi-relay-node

* Add lib to tanssi-relay-node without other networks

* Add overseer to tanssi-relay-node

* Add workers to tanssi-relay-node

* Add relay chain selection to tanssi-relay-node

* Add tests to tanssi-relay-node

* Use polkadot_service::overseer instead of copy

* Add parachains_db

* wip

* Fixes

* Fixes

* Apply toml-maid fixes

* Apply cargo fmt changes

* Apply zepyter changes

* Fixes

* Apply cargo fmt changes

* Remove workers - is being exported by polkadot-sdk

* Remove Error enum and reference polkadot_service::Error

* Combine use statements

* Rename tanssi-relay-node to tanssi-relay-service

* Use polkadot_service::HeaderProviderProvider instead

* Remove relay_chain_selection

* Remove grandpa_support

* Remove unused crate

* Add Tanssi Relay CLI crate as-is

* Remove unnecessary relay node code

* Connect mozart chainspec with tanssi-relay-cli

* Update cli command and remove unrequired chains

* Remove unused cli commands

* Move Mozart runtime down

* Add cli binary root

* Cargo.toml fixes

* Fix typo in Cargo

* Crate fixes

* Cleanup

* Re-add else block for load chain spec

* Remove info

* Remove log statements

* Cargo fmt

* Cargo fmt

* Cargo fmt

* Add mozart_development_config

* Add all mozart chain specs

* Crate clean ups

* Clippy fixes

* Apply cargo +nightly fmt

* Add basic moonwall config for dev_tanssi_relay

* Clippy fixes

* Update moonwall environment for dev_tanssi_relay

* Add dev-tanssi-relay test suite dir

* Migrate weights to use TestWeightInfo

* Migrate XCM config weights

* Add simple chain spec test for dev-tanssi-relay moonwall environment

* Add node cli args that are also on mozart

* Add download-polkadot.sh script to moonwal env

* Add CI step to test dev_tanssi_relay

* Update runtime/mozart/Cargo.toml

Co-authored-by: tmpolaczyk <[email protected]>

* Fix typescript formatting

* Remove unnecessary config

* Copy the tanssi-relay binary in CI

* Add clippy allow

* Rename workers back to polkadot-

* Update chain spec test for mozart

* Remove Generate typescript api for mozart

* Remove polkadot workers from workspace Cargo.toml as moonwall downloads them (but for x86 only)

* Comment-out create-local-interfaces until script is updated and run pnpm install in Run Dev tests

* Simplify ts test

* Add basic issuance and balance checks

* Add ss58Prefix test

* Update chain spec tests

* Remove unused import

* Update tests

* Fix type

* Remove unused import

* Update license

* Update release CI

* Remove workers src code

* Update Cargo.lock

* Change CI for dev_tanssi_relay to verbose to debug

* basic zombienet test

* typescript inting

* Revert changes to release.yaml ci

* Remove unused crates

* Re-org mozart crates

* Move README

* Update FIXME

* Set reporters to basic for dev_tanssi_relay

* Rename mozart to starlight

* Apply toml-maid fixes

* Apply cargo +nightly fmt

---------

Co-authored-by: tmpolaczyk <[email protected]>
Co-authored-by: girazoki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

No branches or pull requests

1 participant