Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network/litep2p: Peerset tracked peers are unbounded #6219

Open
lexnv opened this issue Oct 24, 2024 · 0 comments
Open

network/litep2p: Peerset tracked peers are unbounded #6219

lexnv opened this issue Oct 24, 2024 · 0 comments
Labels
I2-bug The node fails to follow expected behavior. T0-node This PR/Issue is related to the topic “node”.

Comments

@lexnv
Copy link
Contributor

lexnv commented Oct 24, 2024

The tracked peers of each PeerSet grows in an unbounded manner:

polkadot-sdk/substrate/client/network/src/litep2p/shim/notification/peerset.rs

Line 354 in 1a701c9

peers: HashMap<PeerId, PeerState>,

Related to memory leak:

protocol=OnHeap("/b0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe/block-announces/1"), peers=0

protocol=OnHeap("/b0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe/block-announces/1"), peers=92

protocol=OnHeap("/b0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe/block-announces/1"), peers=191

A similar solution to paritytech/litep2p#268 can be adopted as well

cc @paritytech/networking
@lexnv lexnv added this to Networking Oct 24, 2024
@lexnv lexnv added T0-node This PR/Issue is related to the topic “node”. I2-bug The node fails to follow expected behavior. labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. T0-node This PR/Issue is related to the topic “node”.
Projects
Networking
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lexnv