network/litep2p: Reputation not adjusted on peer disconnections

[lexnv]

Peerstore does not implement report_disconnect method to adjust the reputation of peers when they disconnect.

I am wondering what is the impact of not implementing this and if it may contain any side effects wrt connection stability.

polkadot-sdk/substrate/client/network/src/litep2p/peerstore.rs

Lines 190 to 192 in 1a701c9

	fn report_disconnect(&self, _peer: PeerId) {
	unimplemented!();
	}

libp2p

In libp2p the reputation update happens on multiple code paths (disconnects / dial failures), via the protocol controller .dropped() calls:

polkadot-sdk/substrate/client/network/src/protocol/notifications/behaviour.rs

Line 1618 in 1a701c9

.dropped(peer_id);

polkadot-sdk/substrate/client/network/src/protocol_controller.rs

Lines 454 to 456 in 1a701c9

	fn report_disconnect(&mut self, peer_id: PeerId) {
	self.peer_store.report_disconnect(peer_id.into());
	}

cc @paritytech/networking