-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve frame-omni-bencher docs #6392
Comments
Let me take a crack at it @iulianbarbu |
Thanks @rainbow-promise , go for it. Assigned this to you. |
hey @rainbow-promise ! How is it going? Please let us know if you encounter blockers with this, and no worries if you haven't got a chance to start it, just thought about checking in. |
Hey @iulianbarbu, currently working on this #6321 Should have a PR by the week and thanks for checking in 😁 |
Amazing, take your time. Looking forward to the PR when it's ready. 😄 |
Hello @iulianbarbu Wondering if I need to build a custom pallet and runtime similar to:
Or I could create a command that builds the westend runtime and bench a specific pallet? |
Hey @rainbow-promise ! First of all sorry for the late reply and thanks for opening the draft PR for this!
We can use the runtimes |
Straight-forward changes:
staging-chain-spec-builder
, and exported to the docs by usingdocify::export_content
README.docify.md
as we did withstaging-chain-spec-builder
again, by running acargo
command with--features generate-readme
.include_str
ed into a lib.rs (even if the crate is intended to be a binary create) - currently the README's content is duplicated as public docs forcommand.rs
::Command
struct, which isn't displayed/used anywhere.docs.rs
will show something like below (which I assume is taken from crates.io):Not a must, but good practice related, as we did with
staging-chain-spec-builder
:cmd_lib::run_cmd
or othercmd_lib
alternative, based on the assertion logic needs.The text was updated successfully, but these errors were encountered: