network/libp2p: Peerset bug trying to add an already reserved node

[lexnv]

2024-11-21 16:21:42.807  WARN tokio-runtime-worker peerset: Trying to add an already reserved node 12D3KooWLgeWvXXrS4H6p626s2E4H7V2UvkfxgcHTBkyQZ4vCwBT as reserved on SetId(3).

Grafana link: https://grafana.teleport.parity.io/goto/KHDabd7NR?orgId=1.

cc @paritytech/sdk-node

[alexggh]

Looked at this warning in the past and I concluded is harmless, so probably the easy fix here is to make it a debug log.

[dmitry-markin]

This is indeed harmless and IIRC I made it warn for node operators to notice when adding already reserved nodes manually. As we abuse the reserved nodes mechanism for other protocol peer set following, this warning is not informative.