Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omni-node: Add test for dev-mode #7452

Open
skunert opened this issue Feb 4, 2025 · 2 comments · May be fixed by #7511
Open

omni-node: Add test for dev-mode #7452

skunert opened this issue Feb 4, 2025 · 2 comments · May be fixed by #7511
Labels
I5-enhancement An additional feature request.

Comments

@skunert
Copy link
Contributor

skunert commented Feb 4, 2025

We should have a integration test or a zombienet test that verifies that freshly built runtimes are able to produce some blocks without error when passed to an omninode in dev mode.
@skunert skunert added the I5-enhancement An additional feature request. label Feb 4, 2025
@skunert skunert moved this to Milestone 2 in Polkadot Omni Node Feb 4, 2025
@MrishoLukamba
Copy link
Contributor

am taking it @skunert

@skunert
Copy link
Contributor Author

skunert commented Feb 4, 2025

Thank you!
We actually have some tests already that you can take inspiration from:

polkadot-sdk/docs/sdk/src/guides/your_first_node.rs

Line 121 in 4c28354

}

What I would like to see is a test that checks that the dev-mode works with the chain-spec that is present here . Support for this chain-spec broke silently and we should detect it.

@MrishoLukamba MrishoLukamba linked a pull request Feb 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I5-enhancement An additional feature request.
Projects
Polkadot Omni Node
Status: Milestone 2
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(integration test) test omni node dev mod work with dev_json file MrishoLukamba/polkadot-sdk
2 participants
@skunert @MrishoLukamba