Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish chain-spec-builder #4518

Merged
merged 7 commits into from
May 29, 2024
Merged

Publish chain-spec-builder #4518

merged 7 commits into from
May 29, 2024

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented May 20, 2024 •
edited by bkontur
Loading

marking it as release-able, attaching the same version number that is attached to other binaries such as polkadot and polkadot-parachain.

I have more thoughts about the version number, though. The chain-spec builder is mainly a user of the sp-genesis-builder api. So the versioning should be such that it helps users know give a version of sp-genesis-builder in their runtime, which version of chain-spec-builder should they use?

With this, we can possibly alter the version number to always match sp-genesis-builder.

Fixes #4352

@kianenigma kianenigma added the R0-silent Changes should not be mentioned in any release notes label May 20, 2024
@kianenigma
Copy link
Contributor Author

@michalkucharczyk do you have further ideas about the version number to be used here?

@michalkucharczyk
Copy link
Contributor

@michalkucharczyk do you have further ideas about the version number to be used here?

What you proposed is fine for me.

@bkontur
Copy link
Contributor

bkontur commented May 24, 2024

I updated the description, release artifacts are done here: #4557

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6319025

@bkontur
Copy link
Contributor

bkontur commented May 28, 2024

I think we can merge this.

@kianenigma
And to the same/aligned versioning for sp-genesis-builder and staging-chain-spec-builder, afaiu, it does not make sense to do any version toml magic/checks in the master branch, because we don't care about [package.version] in the master branch,
e.g. pallet-balances in the master has 28.0.0 but actual release version is 35.0.0. Also sp-genesis-builder has 0.8.0 in the master and latest creates.io release has 0.13.0.

But for every published release we have e.g. release-crates-io-v1.12.0/Plan.toml which is probably generated by parity-publish tool, so I think that this tool is responsible for correct versions uploaded to the crates.io.

Thus, I think that this tool or release process to crates.io should take care about keeping the same version for the modules: sp-genesis-builder and staging-chain-spec-builder.

@Morganamilo wdyt?

@bkontur bkontur mentioned this pull request May 28, 2024
Merged
4 tasks
@kianenigma
Copy link
Contributor Author

@bkontur Thanks for the detailed explanation.

afaiu, it does not make sense to do any version toml magic/checks in the master branch, because we don't care about [package.version] in the master branch,

My understanding is that this is a temporary state and we will eventually move to a system where the versions in master or more or less representative of reality. But someone from the release task force should confirm this (@liamaharon @ggwpez)

In either case, I am happy to merge this even if the version sync is not perfect yet. But, if my assumption above is not correct, please make an issue such that we can the end goal.

Also, @michalkucharczyk do you foresee any further breaking changes to the runtime apis? if not, I am over-thinking all of this :D

github-merge-queue bot pushed a commit that referenced this pull request May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
89604da 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev added a commit that referenced this pull request May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
320cea6 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev added a commit that referenced this pull request May 29, 2024
@EgorPopelyaev @bkontur
Add omni bencher & chain-spec-builder bins to release (#4557)
77cf446 
Closes: #4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
@bkontur bkontur mentioned this pull request May 29, 2024
Open
@bkontur
Copy link
Contributor

bkontur commented May 29, 2024

In either case, I am happy to merge this even if the version sync is not perfect yet. But, if my assumption above is not correct, please make an issue such that we can the end goal.

@kianenigma @ggwpez @liamaharon @Morganamilo @michalkucharczyk please, continue discussion here: #4626

@bkontur bkontur added this pull request to the merge queue May 29, 2024
@bkontur
Copy link
Contributor

bkontur commented May 29, 2024 •
edited by EgorPopelyaev
Loading

@EgorPopelyaev @Morganamilo
guys, when this is merged, we need to:

Merged via the queue into master with commit dfcfa4a May 29, 2024
154 of 155 checks passed
@bkontur bkontur deleted the kiz-publish-chain-spec branch May 29, 2024 08:56
EgorPopelyaev pushed a commit that referenced this pull request May 30, 2024
@kianenigma @bkontur @EgorPopelyaev
Publish chain-spec-builder (#4518)
9970c63 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request May 30, 2024
@kianenigma @bkontur @EgorPopelyaev
Publish chain-spec-builder (#4518)
afd8337 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes #4352

- [x] Add to release artifacts ~~similar to
#4405 done here:
#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
ordian added a commit that referenced this pull request May 30, 2024
@ordian
Merge branch 'master' into ao-statement-distribution-reenabling-prep
9684df4 
* master: (93 commits)
  Fix broken windows build (#4636)
  Beefy client generic on aduthority Id (#1816)
  pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620)
  Broker new price adapter (#4521)
  Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621)
  Update README.md (#4623)
  Publish `chain-spec-builder` (#4518)
  Add omni bencher & chain-spec-builder bins to release (#4557)
  Moves runtime macro out of experimental flag (#4249)
  Filter workspace dependencies in the templates (#4599)
  parachain-inherent: Make `para_id` more prominent (#4555)
  Add metric to measure the time it takes to gather enough assignments (#4587)
  Improve On_demand_assigner events (#4339)
  Conditional `required` checks (#4544)
  [CI] Deny adding git deps (#4572)
  [subsytem-bench] Remove redundant banchmark_name param (#4540)
  Add availability-recovery from systematic chunks (#1644)
  Remove workspace lints from templates (#4598)
  `sc-chain-spec`: deprecated code removed (#4410)
  [subsystem-benchmarks] Add statement-distribution benchmarks (#3863)
  ...
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@EgorPopelyaev @bkontur @hitchhooker
Add omni bencher & chain-spec-builder bins to release (paritytech#4557)
b89eb60 
Closes: paritytech#4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](paritytech#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@kianenigma @bkontur @hitchhooker
Publish chain-spec-builder (paritytech#4518)
f8dd3dc 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes paritytech#4352

- [x] Add to release artifacts ~~similar to
paritytech#4405 done here:
paritytech#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
@bkontur bkontur mentioned this pull request Jul 23, 2024
Open
3 tasks
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@EgorPopelyaev @bkontur @TarekkMA
Add omni bencher & chain-spec-builder bins to release (paritytech#4557)
c0d6451 
Closes: paritytech#4354

This PR adds the steps to build and attach `frame-omni-bencher` and
`chain-spec-builder` binaries to the release draft

## TODO
- [x] add also chain-spec-builder binary
- [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I
want it to match the version of the sp-genesis-builder crate`~~ see
[comment](paritytech#4518 (comment))
- [ ] Backport to `[email protected]` release, so we can use it for next
fellows release: polkadot-fellows/runtimes#324
- [ ] Backport to `[email protected]` release

---------

Co-authored-by: Branislav Kontur <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@kianenigma @bkontur @TarekkMA
Publish chain-spec-builder (paritytech#4518)
3fedbd6 
marking it as release-able, attaching the same version number that is
attached to other binaries such as `polkadot` and `polkadot-parachain`.

I have more thoughts about the version number, though. The chain-spec
builder is mainly a user of the `sp-genesis-builder` api. So the
versioning should be such that it helps users know give a version of
`sp-genesis-builder` in their runtime, which version of
`chain-spec-builder` should they use?

With this, we can possibly alter the version number to always match
`sp-genesis-builder`.

Fixes paritytech#4352

- [x] Add to release artifacts ~~similar to
paritytech#4405 done here:
paritytech#4557

---------

Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gupnik gupnik gupnik approved these changes

@bkontur bkontur bkontur approved these changes

@bkchr bkchr bkchr approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release chain-spec-builder
6 participants
@kianenigma @michalkucharczyk @bkontur @paritytech-cicd-pr @bkchr @gupnik