Expose types from sc-service

[RomarQ]

Description

At moonbeam we have worked on a lazy-loading feature which is a client mode that forks a live parachain and fetches its state on-demand, we have been able to do this by duplicating some code from sc_service::client. The objective of this PR is to simplify the implementation by making public some types in polkadot-sdk.

• Modules:
  • sc_service::client I do not see a point to only expose this type when test-helpers feature is enabled

Integration

Not applicable, the PR just makes some types public.

Review Notes

The changes included in this PR give more flexibility for client developers by exposing important types.

[bkchr]

• sc_service::client I do not see a point to only expose this type when test-helpers feature is enabled

This feature should not exist at all...

Could you give some more details on how you implemented this? I mean why do you need to expose these types at all? I would say that you only need to write some Backend that fetches the values on demand (for sure it would not be async and whatever, but we don't support this any way right now).

[RomarQ]

• sc_service::client I do not see a point to only expose this type when test-helpers feature is enabled

This feature should not exist at all...

Could you give some more details on how you implemented this? I mean why do you need to expose these types at all? I would say that you only need to write some Backend that fetches the values on demand (for sure it would not be async and whatever, but we don't support this any way right now).

We had to change the CallExecutor because of some validation in contextual_call, but there was no way to pass it to a Client instance without the use of test-helpers feature.

[bkchr]

`` because of some validation in contextual_call

Which validation? Could you be more specific?

[RomarQ]

`` because of some validation in contextual_call

Which validation? Could you be more specific?

It was the as_trie_backend when recording is enabled, we cannot convert the lazy loading to a trie backend since we only have access to the state on-demand.

[bkchr]

Dumb question, could you not just use a custom CallExecutor that wraps the LocalCallExecutor and always forwards recorder as None?

[RomarQ]

Dumb question, could you not just use a custom CallExecutor that wraps the LocalCallExecutor and always forwards recorder as None?

The Client struct is still not public without the use of test-helpers feature. About wrapping LocalCallExecutor, it is for sure possible, I have updated the PR.

[bkchr]

Can you please remove the test-helpers feature completely?

[RomarQ]

Can you please remove the test-helpers feature completely?

Sure, will have a look at it 👍

[bkchr]

/cmd prdoc --bump major --audience node_dev

[github-actions]

Command "prdoc --bump major --audience node_dev" has failed ❌! See logs here

[RomarQ]

/cmd prdoc --bump major --audience node_dev

added the PRdoc

[RomarQ]

@bkchr can this PR be merged?