Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AHM] Poke deposits: Multisig pallet #7700

Merged
merged 14 commits into from
Feb 27, 2025
Merged

[AHM] Poke deposits: Multisig pallet #7700

merged 14 commits into from
Feb 27, 2025
+1,218 −507

Conversation

UtkarshBhardwaj007
Copy link
Contributor

@UtkarshBhardwaj007 UtkarshBhardwaj007 commented Feb 24, 2025 •
edited
Loading

Description

  • This PR adds a new extrinsic poke_deposit to pallet-multisig. This extrinsic will be used to re-adjust the deposits made in the pallet to create a multisig operation after AHM.
  • Part of Re-consideration poke for Deposits  #5591

Review Notes

  • Added a new extrinsic poke_deposit in pallet-multisig.
  • Added a new event DepositPoked to be emitted upon a successful call of the extrinsic.
  • Although the immediate use of the extrinsic will be to give back some of the deposit after the AH-migration, the extrinsic is written such that it can work if the deposit decreases or increases (both).
  • The call to the extrinsic would be free if an actual adjustment is made to the deposit and paid otherwise.
  • Added tests to test all scenarios.

TO-DOs

  • Add Benchmark
  • Run CI cmd bot to benchmark

@UtkarshBhardwaj007 UtkarshBhardwaj007 requested a review from a team as a code owner February 24, 2025 19:42
@UtkarshBhardwaj007 UtkarshBhardwaj007 marked this pull request as draft February 24, 2025 19:43
@UtkarshBhardwaj007
Copy link
Contributor Author

/cmd fmt

@UtkarshBhardwaj007
Copy link
Contributor Author

/cmd prdoc

@UtkarshBhardwaj007
Copy link
Contributor Author

/cmd bench --pallet pallet_multisig

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_multisig" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_multisig" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
polkadot/runtime/westend/src/weights/pallet_multisig.rs as_multi_threshold_1 20.94us 26.53us +26.70
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_multisig.rs as_multi_threshold_1 20.63us 25.62us +24.19
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_multisig.rs as_multi_threshold_1 20.94us 24.27us +15.92
polkadot/runtime/rococo/src/weights/pallet_multisig.rs as_multi_threshold_1 20.98us 22.88us +9.05
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_multisig.rs as_multi_threshold_1 20.82us 22.43us +7.70
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_multisig.rs as_multi_threshold_1 20.82us 21.91us +5.23
cumulus/parachains/runtimes/coretime/coretime-rococo/src/weights/pallet_multisig.rs as_multi_threshold_1 22.46us 21.15us -5.81
substrate/frame/multisig/src/weights.rs poke_deposit 164.53us Added
polkadot/runtime/westend/src/weights/pallet_multisig.rs poke_deposit 177.80us Added
polkadot/runtime/rococo/src/weights/pallet_multisig.rs poke_deposit 175.24us Added
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_multisig.rs poke_deposit 171.47us Added
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_multisig.rs poke_deposit 170.38us Added
cumulus/parachains/runtimes/coretime/coretime-westend/src/weights/pallet_multisig.rs poke_deposit 171.66us Added
cumulus/parachains/runtimes/coretime/coretime-rococo/src/weights/pallet_multisig.rs poke_deposit 169.08us Added
cumulus/parachains/runtimes/contracts/contracts-rococo/src/weights/pallet_multisig.rs poke_deposit 168.04us Added
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_multisig.rs poke_deposit 170.81us Added
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_multisig.rs poke_deposit 176.46us Added
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_multisig.rs poke_deposit 176.62us Added
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_multisig.rs poke_deposit 172.08us Added
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_multisig.rs poke_deposit 171.04us Added
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_multisig']
-- westend: ['pallet_multisig']
-- rococo: ['pallet_multisig']
-- asset-hub-westend: ['pallet_multisig']
-- asset-hub-rococo: ['pallet_multisig']
-- bridge-hub-rococo: ['pallet_multisig']
-- bridge-hub-westend: ['pallet_multisig']
-- collectives-westend: ['pallet_multisig']
-- contracts-rococo: ['pallet_multisig']
-- coretime-rococo: ['pallet_multisig']
-- coretime-westend: ['pallet_multisig']
-- people-rococo: ['pallet_multisig']
-- people-westend: ['pallet_multisig']

@UtkarshBhardwaj007 UtkarshBhardwaj007 marked this pull request as ready for review February 25, 2025 10:02
@UtkarshBhardwaj007 UtkarshBhardwaj007 added T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. labels Feb 25, 2025
@UtkarshBhardwaj007 UtkarshBhardwaj007 mentioned this pull request Feb 25, 2025
Open
7 tasks
re-gius
re-gius approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

muharem
muharem reviewed Feb 27, 2025
View reviewed changes
@UtkarshBhardwaj007
Copy link
Contributor Author

/cmd fmt

@UtkarshBhardwaj007
Copy link
Contributor Author

/cmd prdoc

@UtkarshBhardwaj007 UtkarshBhardwaj007 added this pull request to the merge queue Feb 27, 2025
Merged via the queue into paritytech:master with commit cc83fba Feb 27, 2025
245 of 253 checks passed
@UtkarshBhardwaj007 UtkarshBhardwaj007 deleted the poke-multisig branch February 27, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muharem muharem muharem approved these changes

@re-gius re-gius re-gius approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UtkarshBhardwaj007 @muharem @re-gius