Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print whom to can ping for an approval #109

Closed
Tracked by #101
ggwpez opened this issue Jan 9, 2024 · 1 comment
Closed
Tracked by #101

Print whom to can ping for an approval #109

ggwpez opened this issue Jan 9, 2024 · 1 comment

Comments

@ggwpez
Copy link
Member

ggwpez commented Jan 9, 2024

Eg the output here tells me that it counted Basti and needs more rank 3 approvals: https://github.com/polkadot-fellows/runtimes/pull/133/checks?check_run_id=20196675519

Maybe it can also list all people that i can ping? I think the info should be available, or?

@Bullrich
Copy link
Contributor

Bullrich commented Feb 5, 2024

Hi @ggwpez!

This has been done in #112

Version 2.4.0 prints two lists:

  • One which shows whose review counts towards an unfulfilled rule.
  • One which shows which users' approval would count towards this rule, so with this you can request their reviews

The PR to update Review-bot to 2.4.0 are the following:

You can find a working example here 📗

I hope this fulfills your request 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants