fix: add xcmVersion in DryRunCall (#1649)

* fix: add xcmVersion in DryRunCall

* update code to get the latest metadata version

* updating tests (attempt)

* Fv domi fix dryrun (#1662)

* wip:tests

* Fix metadata issue

* fix tests for TxDryRun

* running tests for dryrun

* cleanup

---------

Co-authored-by: tarikgul <[email protected]>

* Fix test results

---------

Co-authored-by: Filippo <[email protected]>
Co-authored-by: tarikgul <[email protected]>

Author: 3 people

src/controllers/transaction/TransactionDryRunController.ts

@@ -20,6 +20,7 @@ import { BadRequest } from 'http-errors';
 import { TransactionDryRunService } from '../../services';
 import { IPostRequestHandler, ITx } from '../../types/requests';
 import AbstractController from '../AbstractController';
+
 /**
  * Dry run a transaction.
  *
@@ -60,7 +61,7 @@ export default class TransactionDryRunController extends AbstractController<Tran
 	}
 
 	private dryRunTransaction: IPostRequestHandler<ITx> = async (
-		{ body: { tx, at, senderAddress } },
+		{ body: { tx, at, senderAddress, xcmVersion } },
 		res,
 	): Promise<void> => {
 		if (!tx) {
@@ -71,8 +72,11 @@ export default class TransactionDryRunController extends AbstractController<Tran
 			throw new BadRequest('Missing field `senderAddress` on request body.');
 		}
 
-		const hash = at ? await this.getHashFromAt(at) : undefined;
+		const hash = await this.getHashFromAt(at);
 
-		TransactionDryRunController.sanitizedSend(res, await this.service.dryRuntExtrinsic(senderAddress, tx, hash));
+		TransactionDryRunController.sanitizedSend(
+			res,
+			await this.service.dryRuntExtrinsic(senderAddress, tx, hash, xcmVersion),
+		);
 	};
 }

src/services/runtime/RuntimeMetadataService.spec.ts

@@ -16,17 +16,15 @@
 
 import { sanitizeNumbers } from '../../sanitize/sanitizeNumbers';
 import { blockHash789629, defaultMockApi } from '../test-helpers/mock';
-import response789629 from '../test-helpers/responses/runtime/metadata789629.json';
+import response from '../test-helpers/responses/runtime/responseV15.json';
 import { RuntimeMetadataService } from './RuntimeMetadataService';
 
 const runtimeMetadataService = new RuntimeMetadataService(defaultMockApi);
 
 describe('RuntimeMetadataService', () => {
 	describe('fetchMetadata', () => {
 		it('works when ApiPromise works (block 789629)', async () => {
-			expect(sanitizeNumbers(await runtimeMetadataService.fetchMetadata(blockHash789629))).toStrictEqual(
-				response789629,
-			);
+			expect(sanitizeNumbers(await runtimeMetadataService.fetchMetadata(blockHash789629))).toStrictEqual(response);
 		});
 	});
 });

src/services/runtime/RuntimeMetadataService.ts

@@ -15,8 +15,7 @@
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 import { ApiDecoration } from '@polkadot/api/types';
-import { Metadata } from '@polkadot/types';
-import type { Option } from '@polkadot/types/codec';
+import { Metadata, Option } from '@polkadot/types';
 import type { BlockHash, OpaqueMetadata } from '@polkadot/types/interfaces';
 import { InternalServerError } from 'http-errors';
 
@@ -68,7 +67,6 @@ export class RuntimeMetadataService extends AbstractService {
 	async fetchMetadataVersions(hash: BlockHash): Promise<string[]> {
 		const { api } = this;
 		const apiAt = await api.at(hash);
-
 		const availableVersions = (await apiAt.call.metadata.metadataVersions()).toHuman() as string[];
 
 		return availableVersions;