Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Use dependencies from crates-io instead of git deps from the Polkadot SDK repository #301

Closed
stiiifff opened this issue Oct 3, 2023 · 5 comments
Closed

Use dependencies from crates-io instead of git deps from the Polkadot SDK repository #301

stiiifff opened this issue Oct 3, 2023 · 5 comments
Assignees
@ayushmishra2005
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Milestone
Trappist M2 / XCM v3

Comments

@stiiifff
Copy link
Contributor

stiiifff commented Oct 3, 2023

No description provided.

@stiiifff stiiifff added this to the Trappist M2 / XCM v3 milestone Oct 3, 2023
@stiiifff stiiifff added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 3, 2023
@ayushmishra2005 ayushmishra2005 self-assigned this Oct 6, 2023
@metricaez
Copy link
Collaborator

metricaez commented Oct 23, 2023 •
edited
Loading

Hi! During the last day's I have made some progress with this as it was requested by SP team for an emulator use case they wan to try.
They have provided me this versions as reference.
Here is the branch, currently what is left for this to be done is migrating pallet-dex to creates.io dependencies as it is retrieving sp-io v.23 which is generating a conflict.
How would you like to proceed?
Thanks!

@metricaez
Copy link
Collaborator

Update:
Now it's compiling.
Notes:

  • Had to also update pallet-dex but bot failed on a run.
  • Found a small bug that was already fixed here and on the meantime can be manually patched by copying the missing file like this cp /<path-to-polkadot-sdk>/contracts/benchmarks/* ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pallet-contracts-22.0.0/benchmarks

@stiiifff
Copy link
Contributor Author

stiiifff commented Dec 5, 2023

@metricaez @ayushmishra2005 Would be nice to resolve this one soon 🙏️

@Moliholy
Copy link
Contributor

Moliholy commented Dec 5, 2023

@metricaez @ayushmishra2005 Would be nice to resolve this one soon 🙏️

This is already done here.

@stiiifff
Copy link
Contributor Author

stiiifff commented Dec 8, 2023

Closed by #315

@stiiifff stiiifff closed this as completed Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayushmishra2005 ayushmishra2005

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
Trappist M2 / XCM v3
Development

No branches or pull requests
4 participants
@stiiifff @ayushmishra2005 @Moliholy @metricaez