Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Replace DEX pallet by Asset Conversion pallet #281

Open
stiiifff opened this issue Sep 11, 2023 · 0 comments · May be fixed by #309
Open

Replace DEX pallet by Asset Conversion pallet #281

stiiifff opened this issue Sep 11, 2023 · 0 comments · May be fixed by #309
Assignees
Labels
enhancement New feature or request

Comments

@stiiifff
Copy link
Contributor

Trappist includes a DEX pallet implementation of the Uniswap V1 protocol. This pallet was built by a DS engineer as an onboarding project. It has not been battle-tested in a production environment, and has not passed security audits. Additionally, it creates some maintenance effort every time the Trappist runtime is updated to a new Polkadot release.

On the other hand, the Substrate FRAME library now includes the Asset Conversion pallet which implements the Uniswap V2 protocol, is being used as the main DEX on the Asset Hub, and has gone through extensive peer reviews and a security audit(s).

We should therefore replace Trappist’s DEX implementation by the new Asset Conversation pallet, and archive the old DEX pallet’s repository.

@stiiifff stiiifff added the enhancement New feature or request label Sep 11, 2023
@stiiifff stiiifff added this to the Trappist M2 / XCM v3 milestone Sep 11, 2023
@Moliholy Moliholy self-assigned this Nov 7, 2023
@Moliholy Moliholy linked a pull request Nov 7, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants