Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction checks based on genesis hash #87

Open
emostov opened this issue Apr 29, 2021 · 0 comments
Open

Transaction checks based on genesis hash #87

emostov opened this issue Apr 29, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@emostov
Copy link
Contributor

emostov commented Apr 29, 2021

For txwrapper-polkadot: As logic becomes more specialized I think we can code in some helpful warnings. For example, if Statemint is the only chain with pallet-assets, and a governance chain is the only one with pallet-democracy, we can hardcode those genesis hashes into txwrapper-polkadot and log a warning if someone builds a tx with the genesis hash of the wrong chain. Will also be an indicator that you are probably fetching version info from the wrong node.

Originally posted by @joepetrowski in #75 (comment)

@TarikGul TarikGul added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants