Replace usage of deprecated libs/versions of libs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable logging in jupnp for debug builds Use kryo lib from maven repo. Bump kryo version from 2.21 to 5.6.0 Add exceptions to log for kryo's exceptions handling
probably we should extend the CI to also run those tests.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Use jupnp lib instead of cling
Enable logging in jupnp for debug builds
Use kryo lib from maven repo. Bump kryo version from 2.21 to 5.6.0 (5.6.0 is minimal in maven repo)
Add exceptions info to log messages for kryo's exceptions handling
Also add JUPNPTest to detect regression of jupnp/jupnp#232. I know it's a bit out of our scope to test it here, but I wrote the test, so, why not...
Though, if you feel like it's really out of our scope, say it and I will remove it.