You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Essentially the same problem as #49. fileSubDirectory parameter is noted in docs as defaulting to ./files, when in reality it defaults to an empty string, and then resolves any provided value as a path within ./files. The lines that #49 called out are explicitly the problem. This seems to be intentional as noted in said issue, but the docs do not reflect this, and I see no good reason to not allow a user of this library to change the directory to their liking. I'm using this for development only, but I don't want my files to go in ./files at all.
Steps to reproduce
Use this adapter with any fileSubDirectory set
Actual Outcome
the path set for fileSubDirectory is used as a subdirectory of ./files, it does not override the advertised default of ./files
Expected Outcome
the fileSubDirectory should entirely overwrite the ./filesdefault, rather than being appended to it.
if not, the docs in the readme should be updated, ./files is not a default the way it is now.
Environment
Client
Parse Server Push Adapter version: N/A
Server
Parse Server version: 7.2.0
FSAdapter: 3.0.0
Operating system: docker node:20-alpine (alpine linux of some version)
Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local (docker)
Database
System (MongoDB or Postgres): Postgres
Database version: N/A
Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): Local (docker)
Logs
The text was updated successfully, but these errors were encountered:
🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.
New Issue Checklist
Issue Description
Essentially the same problem as #49.
fileSubDirectory
parameter is noted in docs as defaulting to./files
, when in reality it defaults to an empty string, and then resolves any provided value as a path within./files
. The lines that #49 called out are explicitly the problem. This seems to be intentional as noted in said issue, but the docs do not reflect this, and I see no good reason to not allow a user of this library to change the directory to their liking. I'm using this for development only, but I don't want my files to go in./files
at all.Steps to reproduce
Use this adapter with any
fileSubDirectory
setActual Outcome
the path set for
fileSubDirectory
is used as a subdirectory of./files
, it does not override the advertised default of./files
Expected Outcome
the
fileSubDirectory
should entirely overwrite the./files
default, rather than being appended to it.if not, the docs in the readme should be updated,
./files
is not a default the way it is now.Environment
Client
N/A
Server
7.2.0
3.0.0
docker node:20-alpine (alpine linux of some version)
Local (docker)
Database
Postgres
N/A
Local (docker)
Logs
The text was updated successfully, but these errors were encountered: