Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesSubDirectory does not work as advertised #74

Closed
4 tasks done
obermillerk opened this issue Jul 11, 2024 · 2 comments
Closed
4 tasks done

filesSubDirectory does not work as advertised #74

obermillerk opened this issue Jul 11, 2024 · 2 comments

Comments

@obermillerk
Copy link

New Issue Checklist

Issue Description

Essentially the same problem as #49. fileSubDirectory parameter is noted in docs as defaulting to ./files, when in reality it defaults to an empty string, and then resolves any provided value as a path within ./files. The lines that #49 called out are explicitly the problem. This seems to be intentional as noted in said issue, but the docs do not reflect this, and I see no good reason to not allow a user of this library to change the directory to their liking. I'm using this for development only, but I don't want my files to go in ./files at all.

Steps to reproduce

Use this adapter with any fileSubDirectory set

Actual Outcome

the path set for fileSubDirectory is used as a subdirectory of ./files, it does not override the advertised default of ./files

Expected Outcome

the fileSubDirectory should entirely overwrite the ./files default, rather than being appended to it.
if not, the docs in the readme should be updated, ./files is not a default the way it is now.

Environment

Client

  • Parse Server Push Adapter version: N/A

Server

  • Parse Server version: 7.2.0
  • FSAdapter: 3.0.0
  • Operating system: docker node:20-alpine (alpine linux of some version)
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local (docker)

Database

  • System (MongoDB or Postgres): Postgres
  • Database version: N/A
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): Local (docker)

Logs

Copy link

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@obermillerk
Copy link
Author

I overlooked #50, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants