Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unwrap() #933

Open
parmesant opened this issue Sep 20, 2024 · 1 comment
Open

Replace unwrap() #933

parmesant opened this issue Sep 20, 2024 · 1 comment

Comments

@parmesant
Copy link
Contributor

Replace as many unwrap() as possible and replace them with either expect() or Err()
@ByteBaker
Copy link

I'd like to take this.

ByteBaker added a commit to ByteBaker/parseable that referenced this issue Sep 22, 2024
@ByteBaker
chore: multiple improvements
ba9ea48 
It's an overall negative PR, meaning there are more lines deleted than
added. Following changes have been made:

- remove a few `unwrap()`, partly covers parseablehq#933
- replace code with idiomatic version of it
- rewrite `time_from_path` to make it simpler + robust
- rewrite `flatten_objects_for_count` reducing loops and simplify the
  accumulator inside it
- make the Regex in `Message::extract_column_names` static
- correct a few panic messages
@ByteBaker ByteBaker mentioned this issue Sep 22, 2024
Closed
3 tasks
ByteBaker added a commit to ByteBaker/parseable that referenced this issue Sep 23, 2024
@ByteBaker
chore: multiple improvements
08cd2be 
It's an overall negative PR, meaning there are more lines deleted than
added. Following changes have been made:

- remove a few `unwrap()`, partly covers parseablehq#933
- replace code with idiomatic version of it
- rewrite `time_from_path` to make it simpler + robust
- rewrite `flatten_objects_for_count` reducing loops and simplify the
  accumulator inside it
- make the Regex in `Message::extract_column_names` static
- correct a few panic messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ByteBaker @parmesant