Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: do FAT LTO and singular codegen-unit on release #970

Merged
merged 2 commits into from
Dec 17, 2024
Merged

perf: do FAT LTO and singular codegen-unit on release #970

merged 2 commits into from
Dec 17, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Oct 22, 2024 •
edited
Loading

Fixes #224 .

Description

Optimize release builds by building them in a special profile release-lto that:

  1. Enables FAT LTO
  2. Uses codegen-unit = 1
    This is intended to improve the quality of parseable binary compiled at release, in terms of performance and size.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@de-sh
Copy link
Contributor Author

de-sh commented Oct 22, 2024

I have read the CLA Document and I hereby sign the CLA

nitisht added a commit to parseablehq/.github that referenced this pull request Oct 22, 2024
@nitisht
@de-sh has signed the CLA in parseablehq/parseable#970
1e4949c
nitisht
nitisht reviewed Oct 22, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
de-sh
de-sh commented Oct 22, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@de-sh
Copy link
Contributor Author

de-sh commented Dec 17, 2024

Decision on this front, we will move these changes to a specific profile release-lto that will be used during compilation for binary generation on GitHub release.

@de-sh de-sh marked this pull request as ready for review December 17, 2024 08:50
@de-sh de-sh changed the title perf: do thin LTO and singular codegen-unit on release perf: do FAT LTO and singular codegen-unit on release Dec 17, 2024
@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12370139449

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 11.591%
Totals Coverage Status
Change from base Build 12369242409: 0.0%
Covered Lines: 2111
Relevant Lines: 18212
💛 - Coveralls

@de-sh de-sh requested a review from nitisht December 17, 2024 09:10
@nitisht nitisht merged commit fc44fca into parseablehq:main Dec 17, 2024
6 checks passed
@de-sh de-sh deleted the perf branch December 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PGO + Bolt
3 participants
@de-sh @coveralls @nitisht