Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a folding version of the Cat ValueExpression #230

Closed
jvdb opened this issue Nov 26, 2017 · 0 comments · Fixed by #233
Closed

Add a folding version of the Cat ValueExpression #230

jvdb opened this issue Nov 26, 2017 · 0 comments · Fixed by #233
Assignees
Labels
Milestone

Comments

@jvdb
Copy link
Contributor

jvdb commented Nov 26, 2017

As discussed in #229, long chains of concatenated data are a challenge for the 7.0.0 version of ConcatenatedValueSource. In order for a list-based implementation to work without too much instanceof magic, it makes sense to have a version of Cat that simply takes a single ValueExpression operand and then concatenate all the results it evaluates to. This is essentially the same as passing that operand to the Fold ValueExpression and providing the Cat ValueExpression as reducer.

This could be generalized to all BinaryValueExpressions, see #231 for a discussion of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant