[v1] Function data type mismatches (known at compile-time) return missing in strict mode

[alancai98]

Description

Currently, PError.FUNCTION_TYPE_MISMATCH has a default severity of warning. Because of this, the standard error listener used during planning will not give an error in strict mode when there's a function data type mismatch. The function data type mismatch will create a RexError node --

partiql-lang-kotlin/partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/PlanTyper.kt

Lines 757 to 759 in b651415

	false -> PErrors.functionTypeMismatch(null, node.identifier, argTypes, candidates)
	}
	return errorRexAndReport(_listener, problem)

. After planning, that error node will be converted into an ExprMissing node.

To Reproduce

Run the following query in strict mode

'foo' || 123

^ will output missing

If the type involved in the function/operation is not always a data type mismatch, the query will give the expected error at evaluation time:

SELECT v.a + 2 FROM [{'a':1}, {'a':'foo'}] v

^ will error:

org.partiql.errors.TypeCheckException: Could not find function plus with types: [STRING, INTEGER].

Expected Behavior

• Expect the query 'foo' || 123 to give an error in strict mode
• I think we should also make function data type mismatches (PError.FUNCTION_TYPE_MISMATCH) an error by default so the standard error listener will give an error at plan-time

Additional Context

• Java version: 11
• PartiQL version: v1 rc.3
• Add any other context about the problem here.

[RCHowell]

Update https://github.com/partiql/partiql-lang-kotlin/blob/main/partiql-eval/src/main/kotlin/org/partiql/eval/internal/compiler/StandardCompiler.kt#L327-L329 to check mode.

[RCHowell]

We will need to re-enable the spec tests so this gets caught now that we better understand the desired behavior here.