Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed: Prevent redundant verification requests from the widget component #3170

Open
nutrina opened this issue Jan 9, 2025 · 0 comments
Open
Labels
Embed Passport Embed Product

Comments

@nutrina
Copy link
Collaborator

nutrina commented Jan 9, 2025

There are cases where multiple requests are triggered from the UI widget component to the embed service.

Given that this processing is is intensive, we should prevent executing the handler for identical requests if the previous request is still running.

Potential solution: should store a flag in redis when a request handler starts for an address and invalidate that when the request ends (regardless if successfully or with error). In between we should return 429 for every request coming in for that same address). Multiple requests could be triggered by errors in the UI integration of the component.

@nutrina nutrina converted this from a draft issue Jan 9, 2025
@Jkd-eth Jkd-eth changed the title [embed] prevent redundant verification requests from the widget component Embed: Prevent redundant verification requests from the widget component Jan 14, 2025
@Jkd-eth Jkd-eth added the Embed Passport Embed Product label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embed Passport Embed Product
Projects
Status: Prioritized
Development

No branches or pull requests

2 participants