Skip to content
This repository has been archived by the owner on Dec 30, 2018. It is now read-only.

Documentation: Tell somewhere which extra files you need to include #131

Closed
marcalj opened this issue Oct 7, 2015 · 5 comments
Closed

Comments

@marcalj
Copy link

marcalj commented Oct 7, 2015

For instance (v0.13):

<!-- begin angular-masonry -->
<script src="bower_components/jquery-bridget/jquery.bridget.js"></script>
<script src="bower_components/get-style-property/get-style-property.js"></script>
<script src="bower_components/get-size/get-size.js"></script>
<script src="bower_components/eventEmitter/EventEmitter.js"></script>
<script src="bower_components/eventie/eventie.js"></script>
<script src="bower_components/doc-ready/doc-ready.js"></script>
<script src="bower_components/matches-selector/matches-selector.js"></script>
<script src="bower_components/fizzy-ui-utils/utils.js"></script>
<script src="bower_components/outlayer/item.js"></script>
<script src="bower_components/outlayer/outlayer.js"></script>
<script src="bower_components/masonry/masonry.js"></script>
<script src="bower_components/imagesloaded/imagesloaded.js"></script>
<script src="bower_components/angular-masonry/angular-masonry.js"></script>
<!-- end angular-masonry -->
@ghillert
Copy link

Thanks for posting this! +1

@juegas
Copy link

juegas commented Oct 26, 2015

I'm using yo:angular generator and the above snippet worked for me in regards to the dependencies. But when I grunt build on the project bower seems to remove item.js from the final output.

I believe it is related to issue #100. I've tried messing with bower.json file as mentioned but item.js continues to be removed in dist.

Is anyone else having this issue upon build?

@juegas
Copy link

juegas commented Oct 27, 2015

Okay I found the source of the source of issue metafizzy/outlayer#33. Looks like a bower thing that is waiting to be PR'd on that project. Adding the following to my bower.json did the trick for me at long last.

"overrides": {
    "outlayer": {
      "main": [
        "item.js",
        "outlayer.js"
      ]
    }
  }

@thomasMary
Copy link

+1

@omriAckley
Copy link
Contributor

As of today using npm here's what worked for me:

<!-- begin angular-masonry -->
<script src="node_modules/jquery/dist/jquery.js"></script>
<script src="node_modules/jquery-bridget/jquery.bridget.js"></script>
<script src="node_modules/desandro-get-style-property/get-style-property.js"></script>
<script src="node_modules/get-size/get-size.js"></script>
<script src="node_modules/wolfy87-eventemitter/EventEmitter.js"></script>
<script src="node_modules/eventie/eventie.js"></script>
<script src="node_modules/doc-ready/doc-ready.js"></script>
<script src="node_modules/desandro-matches-selector/matches-selector.js"></script>
<script src="node_modules/fizzy-ui-utils/utils.js"></script>
<script src="node_modules/outlayer/item.js"></script>
<script src="node_modules/outlayer/outlayer.js"></script>
<script src="node_modules/masonry-layout/masonry.js"></script>
<script src="node_modules/imagesloaded/imagesloaded.js"></script>
<script src="node_modules/angular/angular.js"></script>
<script src="node_modules/angular-masonry/angular-masonry.js"></script>
<!-- end angular-masonry -->

For anybody struggling, the order of those is very important. In particular, angular.js should come after jquery.js—no doubt so that angular will load with jquery instead of jqlite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants