Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization recommendation in README is a hazard and should be removed #259

Open
aaronjensen opened this issue Jul 24, 2024 · 0 comments
Open

Comments

@aaronjensen
Copy link

Without enough consideration, I added this to our code:

https://github.com/patrick-steele-idem/morphdom?tab=readme-ov-file#can-i-make-morphdom-blaze-through-the-dom-tree-even-faster-yes

A year or so later, we started to observe problems with radio button groups that were moved in the DOM. Morphdom would fail to ensure that the value was set properly. Removing this optimization corrected the problem after nearly a day of total investigation.

I'd recommend removing this or somehow updating it to not have the problem I mentioned. I don't think I'll be able to produce a test harness to reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant