Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onChange event firing even when value is not changed #88

Open
ret2jazzy opened this issue Apr 8, 2019 · 1 comment
Open

onChange event firing even when value is not changed #88

ret2jazzy opened this issue Apr 8, 2019 · 1 comment

Comments

@ret2jazzy
Copy link

The onChange event of a select tag gets fired in some cases when the options are altered programmatically. This should not happen as the onChange event should only fire when the user actually changes the value himself.

Here is a tiny example (this took me a lot of time to isolate)

<html>
   <head>
      <script src="static/js/libs/easydropdown/easydropdown.js"></script>
   </head>
   <body>
      <select id="OPT1">
         <option value="E1">E1</option>
      </select>
      <script>
         document.body.onload = ()=> {
             document.getElementById('OPT1').addEventListener('change', function(){
                 alert("Shouldn't be called");
             })
         
             easydropdown.all()

            document.getElementById('OPT1').remove(0) //remove the option

             //add a new option, this will trigger an onChange and an alert will pop up
             let opt = document.createElement("option");
             opt.text = "TEST"
             opt.value = "MODE3";
             document.getElementById('OPT1').add(opt);

         }
 
         
      </script>
   </body>
</html>

Basically, create a select tag with a option, remove the option and then add another option. This leads to the firing of the onChange event. The above snippet will pop an alert() whereas it shouldn't.
@ret2jazzy
Copy link
Author

@patrickkunka if you could take a look? I am not able to follow your code that closely to pinpoint the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ret2jazzy