Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently Added - Missing Icons for some Channel #6

Open
Countryen opened this issue Apr 20, 2019 · 1 comment
Open

Recently Added - Missing Icons for some Channel #6

Countryen opened this issue Apr 20, 2019 · 1 comment

Comments

@Countryen
Copy link

Hey there,
noticed that some of the icons at the top of the Recently Added feed (filter icons) are missing:
image

Chrome, Windows 10.
Extension v3.8.0

@patrickmaher
Copy link
Owner

Thank you. I haven't had a chance to dig into this issue yet but I will fix it in the next version. It is good to see that the fallback to checkbox worked correctly and the extension is still working properly. Just a bit uglier.

The channel logo/color is hard coded in the extension and associated with the channels unique identifier. My guess is that the unique identifier for Sugar Pine 7 and JT Music has been changed. I'm not sure why RT Engineering would change a unique identifier but that is most likely what has happened.

I never associated a logo with Kinda Funny because Rooster Teeth chose a logo image that is a different shape from all the other channels. I haven't decided how I want to resolve that.

I did send a request to RT Engineering to ask them to include channel color and logo in their API. That would allow me to pull that information from the API instead of hard coding it into the extension. Last time I checked they had added a data field for channel color to the API but some of the channels had no color assigned. I will check again when I go to fix this issue.

@patrickmaher patrickmaher self-assigned this Apr 25, 2019
@patrickmaher patrickmaher removed their assignment Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants