Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Wizard - cannot customize height in modal #10144

Closed
dlabrecq opened this issue Mar 8, 2024 · 2 comments · Fixed by #10332
Closed

Bug - Wizard - cannot customize height in modal #10144

dlabrecq opened this issue Mar 8, 2024 · 2 comments · Fixed by #10332
Assignees

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Mar 8, 2024

The wizard's height property appears to be ignored. For example, setting height=1000 had no effect; although, I could see the property output in the browser console.

Screenshot 2024-03-08 at 11 42 33 AM

See https://www.patternfly.org/components/wizard#within-modal

@mcoker
Copy link
Contributor

mcoker commented Mar 22, 2024

Hey @dlabrecq! Thanks for the issue, that's a bug we need to fix. I created an issue in core for that work (patternfly/patternfly#6457), but I think it will be breaking so I've slated it for work in our upcoming penta release.

For the time being, would you be able to add a custom style for that wizard in a modal? Adding --pf-v5-c-modal-box--c-wizard--FlexBasis: 1234px; either as an inline style on <Wizard> or in a stylesheet like .pf-v5-c-wizard.some-custom-class { --pf-v5-c-modal-box--c-wizard--FlexBasis: 1234px; } would work.

@tlabaj tlabaj added the PF6 label Apr 10, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Apr 10, 2024
@kmcfaul kmcfaul self-assigned this May 15, 2024
@kmcfaul kmcfaul linked a pull request May 15, 2024 that will close this issue
@kmcfaul kmcfaul moved this from Needs info to PR Review in PatternFly Issues May 15, 2024
@tlabaj
Copy link
Contributor

tlabaj commented May 28, 2024

cosed by #10332

@tlabaj tlabaj closed this as completed May 28, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants