Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar - add support for background color variants #10226

Closed
mcoker opened this issue Mar 29, 2024 · 0 comments · Fixed by #10284
Closed

Toolbar - add support for background color variants #10226

mcoker opened this issue Mar 29, 2024 · 0 comments · Fixed by #10284
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented Mar 29, 2024

The toolbar was updated to have a transparent background by default, and a primary background when sticky. We added 3 modifier classes to be used with regular and sticky toolbars to customize the background color

  • .pf-m-primary - updates to use the primary background color
  • .pf-m-secondary - ^ but secondary
  • .pf-m-no-background - ^ transparent background

We'll need to make sure react has the version of core, v6.0.0-alpha.112 or greater.

  • You can verify which version of core react is on by looking at the version for the @patternfly/patternfly package in react-styles/package.json
  • If it's not up to date, I've bumped the core version this way. Hopefully it works OK!
    • Update the @patternfly/patternfly package version number in react-styles/package.json
    • From the root of the patternfly-react repo on your computer, run this at the terminal - node scripts/verifyPatternflyVersions --fix && yarn

And looks like we can borrow code from the drawer's prop for it's background color variants, colorVariant (but we'll need to add an entry for primary)

colorVariant?: DrawerColorVariant | 'no-background' | 'default' | 'secondary';

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Mar 29, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Apr 1, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Apr 1, 2024
@kmcfaul kmcfaul moved this from Backlog to Not started in PatternFly Issues Apr 1, 2024
@srambach srambach moved this from Not started to In Progress in PatternFly Issues Apr 16, 2024
@srambach srambach moved this from In Progress to PR Review in PatternFly Issues Apr 17, 2024
@srambach srambach linked a pull request Apr 25, 2024 that will close this issue
@srambach srambach moved this from PR Review to Done in PatternFly Issues Apr 29, 2024
@kmcfaul kmcfaul closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants