Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts - Skeleton #10310

Closed
dlabrecq opened this issue Apr 27, 2024 · 1 comment
Closed

Charts - Skeleton #10310

dlabrecq opened this issue Apr 27, 2024 · 1 comment

Comments

@dlabrecq
Copy link
Member

The UX design team wants to show a skeleton in place of an empty state (e.g., when there is no data to graph). A "graph empty state gives more context on what the user can expect" Vs showing a generic empty state.

Notes

  • This is not animated like the existing PatternFly skeletons, just filling label backgrounds grey.
  • Charts shall not provide fake data. Developers can provide their own data to represent their graph if desired.

Design issue
patternfly/patternfly-design#1278

Mocks
https://www.figma.com/proto/N7hImgEN8rnyKmkz34wcuP/PF---Skeleton-charts?page-id=0%3A1&type=design&node-id=2-1397&viewport=328%2C398%2C0.07&t=iYlJZWG8k9Di231C-1&scaling=scale-down
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 27, 2024
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 27, 2024
@dlabrecq
feat(charts): skeletons
e1bd571 
patternfly#10310
@dlabrecq dlabrecq mentioned this issue Apr 27, 2024
Merged
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 27, 2024
@dlabrecq
feat(charts): skeletons
5a745fa 
patternfly#10310
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 27, 2024
@dlabrecq
feat(charts): skeletons
c7a38c0 
patternfly#10310
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 27, 2024
@dlabrecq
feat(charts): skeletons
ebc9c4c 
patternfly#10310
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 27, 2024
@dlabrecq
feat(charts): skeletons
fa7222f 
patternfly#10310
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 28, 2024
@dlabrecq
feat(charts): skeletons
750b5c8 
patternfly#10310
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Apr 29, 2024
@dlabrecq
feat(charts): skeletons
7f1165c 
patternfly#10310
@tlabaj tlabaj moved this from Needs triage to In Progress in PatternFly Issues May 2, 2024
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue May 2, 2024
@dlabrecq
feat(charts): skeletons
e30f305 
patternfly#10310
tlabaj pushed a commit that referenced this issue May 3, 2024
@dlabrecq
feat(charts): skeletons (#10311)
029351e 
* feat(charts): skeletons

#10310

* chore(charts): remove unused comment from skeleton color theme
@dlabrecq dlabrecq mentioned this issue May 3, 2024
Merged
@tlabaj
Copy link
Contributor

tlabaj commented May 8, 2024

closed by #10311

@tlabaj tlabaj closed this as completed May 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlabrecq @tlabaj