Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar - spacer/gap updates #10387

Closed
5 tasks
mcoker opened this issue May 20, 2024 · 2 comments · Fixed by #10418
Closed
5 tasks

Toolbar - spacer/gap updates #10387

mcoker opened this issue May 20, 2024 · 2 comments · Fixed by #10418
Assignees
@thatblindgeye
Milestone
Penta alpha omega...

Comments

@mcoker
Copy link
Contributor

mcoker commented May 20, 2024 •
edited by mattnolting
Loading

Follow up from patternfly/patternfly#6659

Individual toolbar spacers .pf-m-spacer-{val} no longer exist. Instead we've switched to pf-m-gap, row-gap, column-gap

  • Remove spacer={{ ... }}
  • Add column-gap={{ ... }}
    • Applies .pf-m-column-gap-[none/sm/md/lg/xl/2xl]{-on-[breakpoint]}
  • Add row-gap={{ ... }}
    • Applies .pf-m-row-gap-[none/sm/md/lg/xl/2xl]{-on-[breakpoint]}
  • Add gap={{ ... }}
    • Applies .pf-m-gap-[none/sm/md/lg/xl/2xl]{-on-[breakpoint]}
  • Update example using spacer= to highlight updated spacing system (I'll provide guidance here)
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 20, 2024
@mcoker mcoker moved this from Needs triage to Ready to assign in PatternFly Issues May 20, 2024
@mcoker mcoker added this to the Penta alpha omega release milestone May 20, 2024
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues May 21, 2024
@mcoker
Copy link
Contributor Author

mcoker commented May 21, 2024 •
edited
Loading

What about .pf-m-margin-*? Are those classes not meant to be used as individual item spacers? (from patternfly/patternfly#6057)

cc @mattnolting

@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues May 22, 2024
@thatblindgeye thatblindgeye mentioned this issue May 22, 2024
Merged
@mcoker mcoker mentioned this issue May 22, 2024
Closed
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues May 23, 2024
@thatblindgeye thatblindgeye linked a pull request May 23, 2024 that will close this issue
feat(Toolbar): updated spacer props to gap #10418
Merged
@mcoker
Copy link
Contributor Author

mcoker commented May 23, 2024

closed via #10418

@mcoker mcoker closed this as completed May 23, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha omega release
Development

Successfully merging a pull request may close this issue.

feat(Toolbar): updated spacer props to gap thatblindgeye/patternfly-react
2 participants
@mcoker @thatblindgeye