Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Button - aria-disabled is false when button is disabled #11462

Closed
nicolethoen opened this issue Jan 23, 2025 · 1 comment · Fixed by #11478
Closed

Bug - Button - aria-disabled is false when button is disabled #11462

nicolethoen opened this issue Jan 23, 2025 · 1 comment · Fixed by #11478
Assignees
Labels
Milestone

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Jan 23, 2025

In the Button component In both cases (disabled or enabled) aria-disabled is always false.

From @thatblindgeye: "It probably doesnt do any harm when the button is enabled but we still don’t need it… Since it’s probably been an issue for however long it probably wouldn’t hurt much more if they just wait for us to provide a fix, which we could try to get in for this milestone"

Image

Image

reported during the OCP + PF6 migration

@redjhawk
Copy link

FYI, on Patternfly v5.4 it worked properly. I have some tests reading aria-disabled on a wizard footer and it all passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants