Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar - updates spacers to gaps #645

Closed
thatblindgeye opened this issue May 22, 2024 · 0 comments · Fixed by #648
Closed

Toolbar - updates spacers to gaps #645

thatblindgeye opened this issue May 22, 2024 · 0 comments · Fixed by #648
Assignees
Labels

Comments

@thatblindgeye
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#10418

  • ToolbarGroup, ToolbarItem, and ToolbarToggleGroup: removed spacer prop. We could provide a fix that will replace the prop with the gap prop and also update the values passed in (e.g. spacerNone => gapNone, or we could just state that we recommend using our gap, columnGap or rowGap props instead.
  • ToolbarGroup and ToolbarToggleGroup: removed the spaceItems prop. Will probably require just an error message stating we recommend using marginInlineStart and marginInlineEnd props on applicable components instead.

[Description of the breaking change the rules needing to be created]

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant