Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace in log viewer search examples #5

Open
mcoker opened this issue Jun 18, 2021 · 6 comments
Open

Fix whitespace in log viewer search examples #5

mcoker opened this issue Jun 18, 2021 · 6 comments

Comments

@mcoker
Copy link

mcoker commented Jun 18, 2021

There is a leading space before the search match that shouldn't be there.

Screen Shot 2021-06-18 at 1 23 49 PM

@stale
Copy link

stale bot commented Aug 17, 2021

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels Aug 17, 2021
@mcoker
Copy link
Author

mcoker commented Aug 18, 2021

@mcarrano can we add this to an upcoming milestone? It's just a problem with our workspace examples, so it's low priority.

@mcarrano
Copy link
Member

@nicolethoen @evwilkin How should we handle extension issues moving forward. Since log viewer is now a UXD extension, I was assuming we would not track issues in our PF milestones. But what should we do with this and other log viewer issues?

@nicolethoen
Copy link
Contributor

For now, I think that Juntao will create issues and implement fixes with aid from PF. He is sort of modifying it and building on it as he needs for the OpenShift implementation. As he makes changes we can review the PRs and I can tag you for design reviews when appropriate. Once he moves on we will have to discuss ongoing maintenance going forward

@nicolethoen
Copy link
Contributor

But if there are simple tweaks that people want to make in their spare time, I'd say - as Zack often does - feel free to open PRs to make small changes as you have desire and are able :)

@mcarrano
Copy link
Member

That's all fine. But I guess my question remains whether we will add these issues to our PatternFly milestones.

@jessiehuff jessiehuff transferred this issue from patternfly/patternfly Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants