diff --git a/app/src/main/assets/CHANGELOG.txt b/app/src/main/assets/CHANGELOG.txt index 026d2b53b..69c6fb247 100644 --- a/app/src/main/assets/CHANGELOG.txt +++ b/app/src/main/assets/CHANGELOG.txt @@ -1,6 +1,7 @@ 1.7.0: - Swedish translation (thanks contributors!) - Front camera setting (e.g. for tablets) +- Improve feedback - Removed shopping list shortcut due to shortcut limit in most launchers - Bug fixes and improvements diff --git a/app/src/main/java/xyz/zedler/patrick/grocy/fragment/bottomSheetDialog/FeedbackBottomSheetDialogFragment.java b/app/src/main/java/xyz/zedler/patrick/grocy/fragment/bottomSheetDialog/FeedbackBottomSheetDialogFragment.java index e8d0ae93a..91e8a3a10 100644 --- a/app/src/main/java/xyz/zedler/patrick/grocy/fragment/bottomSheetDialog/FeedbackBottomSheetDialogFragment.java +++ b/app/src/main/java/xyz/zedler/patrick/grocy/fragment/bottomSheetDialog/FeedbackBottomSheetDialogFragment.java @@ -29,13 +29,11 @@ import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; -import android.widget.EditText; import androidx.annotation.NonNull; import com.google.android.material.bottomsheet.BottomSheetDialog; import com.google.android.material.bottomsheet.BottomSheetDialogFragment; -import com.google.android.material.textfield.TextInputLayout; import xyz.zedler.patrick.grocy.R; import xyz.zedler.patrick.grocy.util.IconUtil; @@ -100,21 +98,13 @@ public View onCreateView( ); }); - TextInputLayout textInputLayoutFeedback = view.findViewById(R.id.text_input_feedback); - EditText editText = textInputLayoutFeedback.getEditText(); - assert editText != null; - editText.setOnFocusChangeListener((View v, boolean hasFocus) -> { - if(hasFocus) IconUtil.start(view, R.id.image_feedback_box); - }); - - view.findViewById(R.id.button_feedback_send).setOnClickListener(v -> { + view.findViewById(R.id.linear_feedback_email).setOnClickListener(v -> { Intent intent = new Intent(Intent.ACTION_SENDTO); intent.setData( Uri.parse( "mailto:" + getString(R.string.app_mail) + "?subject=" + Uri.encode("Feedback@Grocy") - + "&body=" + Uri.encode(editText.getText().toString()) ) ); startActivity(Intent.createChooser(intent, getString(R.string.action_send_feedback))); diff --git a/app/src/main/res/drawable/ic_round_email.xml b/app/src/main/res/drawable/ic_round_email.xml new file mode 100644 index 000000000..98cada722 --- /dev/null +++ b/app/src/main/res/drawable/ic_round_email.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/layout/fragment_bottomsheet_feedback.xml b/app/src/main/res/layout/fragment_bottomsheet_feedback.xml index 1944e3ecf..ecf7a87ab 100644 --- a/app/src/main/res/layout/fragment_bottomsheet_feedback.xml +++ b/app/src/main/res/layout/fragment_bottomsheet_feedback.xml @@ -29,7 +29,7 @@ android:layout_height="wrap_content" android:orientation="vertical" android:paddingTop="16dp" - android:paddingBottom="12dp" + android:paddingBottom="8dp" android:gravity="center_horizontal"> + android:id="@+id/linear_feedback_email" + style="@style/Theme.Grocy.ListItem.TwoLine.Clickable" + android:background="@drawable/bg_list_item_surface"> - + + + - + - + - - diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index 9b6d9800b..5d5c9953c 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -38,6 +38,8 @@ Einkaufszettel leeren Auf Google Play bewerten Die Entwicklung unterstützen + Email senden + Entwickler kontaktieren Neues Issue auf GitHub öffnen Bugs melden oder einen Vorschlag machen Loslegen @@ -378,7 +380,6 @@ Server URL Gültiger API Schlüssel - Email schreiben Dunkles Theme erzwingen Aus für Systemabhängigkeit diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index 07a44c621..48c9e7c21 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -372,7 +372,6 @@ URL du serveur Clé API valide - Écrire un email Forcer le mode sombre Désactivé pour la dépendance système diff --git a/app/src/main/res/values-sv/strings.xml b/app/src/main/res/values-sv/strings.xml index 56ac3fee3..70edff89b 100644 --- a/app/src/main/res/values-sv/strings.xml +++ b/app/src/main/res/values-sv/strings.xml @@ -378,7 +378,6 @@ Server URL Giltig API-nyckel - Skriv e-post Tvinga mörkt läge Av för att använda systemets inställning diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 0e38405e9..fecb49009 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -43,6 +43,8 @@ Clear shopping list Rate on Google Play Support the development + Send email + Contact the developers Open new issue on GitHub Report bugs or request a feature Get started @@ -384,7 +386,6 @@ Server URL Valid API key - Write email Force dark mode Off for system dependency