Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't ask to add not existing files to the chat #728

Closed
ErykCh opened this issue Jun 25, 2024 · 8 comments
Closed

Shouldn't ask to add not existing files to the chat #728

ErykCh opened this issue Jun 25, 2024 · 8 comments
Labels
question Further information is requested

Comments

@ErykCh
Copy link

ErykCh commented Jun 25, 2024

Issue

Hi,

if it knows that new files must be created than it shouldn't ask to add them to the chat:

image

Version and model info

Aider: 0.40.0
Model: Claude Sonnet 3.5

@paul-gauthier paul-gauthier added the question Further information is requested label Jun 25, 2024
@paul-gauthier
Copy link
Owner

Thanks for trying aider and filing this issue.

This doc may be helpful:

https://aider.chat/docs/troubleshooting/edit-errors.html

@ErykCh
Copy link
Author

ErykCh commented Jun 28, 2024

I would expect Aider to ask to include these files:

Add these files to the chat?

and if I have the --yes option enabled, it will even do it automatically.

@paul-gauthier
Copy link
Owner

Are those files part of your git repo? If you do git ls-files do they show up?

@ErykCh
Copy link
Author

ErykCh commented Jun 30, 2024

No.

another example from a moment ago

image

I thought that /add creates a file if it doesn't exist.

But for me something is missing here.

There is a text: I'll wait for your approval to proceed
But there is no any place to put y

but I must admit that he made the format method very nicely because extracted all the data from the Document class, which is not part of the code because it is from the Spring AI package

But this is a completely different story, how to make sure that if something changes in the public library, he will know about it. For example, a new field will be added to the Document class, how will it know about its existence? Do you expect it will be possible to add code from outside the project repository to the repomap?

Aider v0.40.7-dev
Models: openrouter/anthropic/claude-3.5-sonnet with diff edit format, weak model openrouter/anthropic/claude-3-haiku
Git repo: .git with 35 files
Repo-map: using 2028 tokens

@paul-gauthier
Copy link
Owner

Aider only works with the code in your repo. It can't see code outside the repo.

@ErykCh
Copy link
Author

ErykCh commented Jul 1, 2024

Ok, I understand this.

but what about the problem that the user must accept adding a file but the question about adding a file does not appear?

@paul-gauthier
Copy link
Owner

That was just the LLM talking to you, not aider itself. I think the LLM was a bit confused about the exact way aider works.

@paul-gauthier
Copy link
Owner

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants