Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when adding url #736

Closed
JacquesvanWyk opened this issue Jun 26, 2024 · 4 comments
Closed

Issue when adding url #736

JacquesvanWyk opened this issue Jun 26, 2024 · 4 comments
Labels
bug Something isn't working fixed

Comments

@JacquesvanWyk
Copy link

Issue

I get this error in browser when adding a url

NotImplementedError
Traceback:

File "C:\Python312\Lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 589, in _run_script
exec(code, module.dict)
File "C:\Python312\Lib\site-packages\aider\gui.py", line 543, in
status = gui_main()
^^^^^^^^^^
File "C:\Python312\Lib\site-packages\aider\gui.py", line 539, in gui_main
GUI()
File "C:\Python312\Lib\site-packages\aider\gui.py", line 367, in init
self.do_sidebar()
File "C:\Python312\Lib\site-packages\aider\gui.py", line 150, in do_sidebar
self.do_add_to_chat()
File "C:\Python312\Lib\site-packages\aider\gui.py", line 180, in do_add_to_chat
self.do_add_web_page()
File "C:\Python312\Lib\site-packages\aider\gui.py", line 207, in do_add_web_page
self.do_web()
File "C:\Python312\Lib\site-packages\aider\gui.py", line 488, in do_web
content = self.scraper.scrape(url) or ""
^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\site-packages\aider\scrape.py", line 49, in scrape
self.try_playwright()
File "C:\Python312\Lib\site-packages\aider\scrape.py", line 97, in try_playwright
with sync_playwright() as p:
File "C:\Python312\Lib\site-packages\playwright\sync_api_context_manager.py", line 77, in enter
dispatcher_fiber.switch()
File "C:\Python312\Lib\site-packages\playwright\sync_api_context_manager.py", line 56, in greenlet_main
self._loop.run_until_complete(self._connection.run_as_sync())
File "C:\Python312\Lib\asyncio\base_events.py", line 687, in run_until_complete
return future.result()
^^^^^^^^^^^^^^^
File "C:\Python312\Lib\site-packages\playwright_impl_connection.py", line 263, in run_as_sync
await self.run()
File "C:\Python312\Lib\site-packages\playwright_impl_connection.py", line 272, in run
await self._transport.connect()
File "C:\Python312\Lib\site-packages\playwright_impl_transport.py", line 133, in connect
raise exc
File "C:\Python312\Lib\site-packages\playwright_impl_transport.py", line 120, in connect
self._proc = await asyncio.create_subprocess_exec(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\asyncio\subprocess.py", line 224, in create_subprocess_exec
transport, protocol = await loop.subprocess_exec(
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\asyncio\base_events.py", line 1744, in subprocess_exec
transport = await self._make_subprocess_transport(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\asyncio\base_events.py", line 524, in _make_subprocess_transport
raise NotImplementedError

Version and model info

No response

@paul-gauthier
Copy link
Owner

Thanks for trying aider and filing this issue.

Have you installed playwright?

https://aider.chat/docs/install/optional.html#enable-playwright

It would also be helpful if you can share what verison of aider you are using.

@paul-gauthier paul-gauthier added the question Further information is requested label Jun 27, 2024
@JacquesvanWyk
Copy link
Author

Yes I did install playwright

aider 0.40.5

I am on windows powershell

@paul-gauthier
Copy link
Owner

I've pushed a fix for this issue.

The change is available in the main branch. You can get it by installing the latest version from github:

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

@paul-gauthier paul-gauthier added bug Something isn't working fixed and removed question Further information is requested labels Jul 4, 2024
@JacquesvanWyk
Copy link
Author

I've pushed a fix for this issue.

The change is available in the main branch. You can get it by installing the latest version from github:

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

Thank you the issue is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants