MockFactory reporting unexpected calls at the end of each test #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are not implemented right now, I'd like to receive some feedback first. Is its approach viable for you? Is there any chance to have this merged into the master? |
|
Is there anything I can do to move this on? |
|
Hi, I think this change looks fine in principle, but it doesn't yet have any tests. prerequisite to merging this would be to cover the new functionality in adequate tests, both for the standard case and for the new use-cases. Could you please add these? Then i'll review and give some more detailed feedback. Let's do this and then i'll cut a new release for Scalamock so people can use it |
|
This is now way too old to merge. As stated a while ago, please add some testcases and rebase, then this should be fine to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
[ ] I have added copyright headers to new filesFixes
Fixes #223
Purpose
Introduces
MockFactoryRecordingUnexpectedCalls, which reports all unexpected calls after each test. This is usable especially with asynchronous tests since the original exception can be silently dropped.Background Context
Fully backward compatible, records all unexpected call to be replayed later. Then optionally mixed in Factory verifies the empty call log of unexpected calls.
This approach is 1) backward compatible since it does not change current behavior, 2) still eagerly fails on an unexpected call, and 3) optionally fails again in the event the original failure was ignored.