-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading Old GT3X Format (NHANES) #10
Comments
Referencing the older issue: THLfi/read.gt3x#3 and the PR: THLfi/read.gt3x#2 |
It would certainly be possible, and I think it's essential for I think the most expedient solution would be to modify I'm open to other suggestions too. Thanks for reaching out. |
I think that's the most pragmatic approach but I think there were some
issues with read.gt3x we found. Also much faster than read_gt3x (I believe
due to pre-allocation) for large files. I think a collaboration may be
awesome, but I don't know that author personally.
Best,
John
…On Wed, Sep 25, 2019 at 5:58 PM paulhibbing ***@***.***> wrote:
It would certainly be possible, and I think it's essential for AGread to
have *a* solution for old gt3x files. That said, I don't know if
implementing a new parser is the best approach. For one thing, my timeline
for turning it around would be poor. More importantly, I'm not sure how
much sense it makes to re-write something that's already available in
read.gt3x. (Obviously there's already quite a lot of overlap between the
two, but I don't think that can/should be undone at this point.)
I think the most expedient solution would be to modify AGread::read_gt3x
to check if it's an old format, and then make a call to the read.gt3x
patch if it is. That would be quick and easy, and I'm happy to add
read.gt3x as a remote dependency until it's on CRAN.
I'm open to other suggestions too. Thanks for reaching out.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10?email_source=notifications&email_token=AAIGPLTWSHCGE4V4WRVQIQ3QLPNJBA5CNFSM4I2QCSNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7TRSVY#issuecomment-535238999>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLTVSXHCUS542OUJVL3QLPNJBANCNFSM4I2QCSNA>
.
|
Nor do I... From what I can tell,
The last one allows you to skip parsing packets you don't care about, which could theoretically save you more time than it costs to categorize the packets. However, I think that probably only happens if you have both primary accelerometer and IMU data (from a GT9X device) and want to parse only one of those packet types. |
I think some of the speedups come from pre-allocation. I had done some
modifications on the code, removing push_back commands and it seems to make
the code faster I want to get_header command. I didn’t do a pull request
yet because I haven’t done a sufficient amount of testing
On Fri, Sep 27, 2019 at 10:52 PM paulhibbing ***@***.***> wrote:
Nor do I... From what I can tell, read.gt3x looks to be written by
someone who actually knows what they're doing in C++, which definitely
helps. In that sense, I'm not surprised it's faster. read_gt3x is also
slowed down by:
- a fair number of tests/sanity checks in the backgound
- the printing mechanism (if verbose = TRUE)
- first leafing through the packets and categorizing them by type
The last one allows you to skip parsing packets you don't care about,
which could theoretically save you more time than it costs to categorize
the packets. However, I think that probably only happens if you have both
primary accelerometer and IMU data (from a GT9X device) and want to parse
only one of those packet types.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10?email_source=notifications&email_token=AAIGPLWW4GRYTFYTRWHND2TQL3BHXA5CNFSM4I2QCSNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72PFUQ#issuecomment-536146642>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIGPLQNDNR4J2KKD27U5OLQL3BHXANCNFSM4I2QCSNA>
.
--
Best,
John
|
Sounds good. My recent push may create conflicts with what you've done already -- apologies if that's the case. |
GT3X+ (01 day)_data.zip
For previous formats (https://github.com/actigraph/NHANES-GT3X-File-Format), for example from https://help.theactigraph.com/entries/21688392-GT3X-ActiSleep-Sample-Data, or the attached
GT3X+ (01 day)_data.zip
Using file from GitHub
This is an older format from https://github.com/actigraph/NHANES-GT3X-File-Format
but it was uploaded for this issue
Download data
Read in the Data
Read in using
read.gt3x
Here we had made a patch for the older format to make this work.
Would it be possible to make one for
AGread
?Created on 2019-09-25 by the reprex package (v0.3.0)
Session info
The text was updated successfully, but these errors were encountered: