Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply recommended community standards. #11

Closed
7 tasks done
paulodiovani opened this issue Oct 7, 2019 · 5 comments
Closed
7 tasks done

Apply recommended community standards. #11

paulodiovani opened this issue Oct 7, 2019 · 5 comments
Labels

Comments

@paulodiovani
Copy link
Owner

paulodiovani commented Oct 7, 2019

Github checklist for recommended community standards.

https://github.com/paulodiovani/hacktoberrank/community.

  • Description
  • README
  • Code of conduct
  • Contributing
  • License
  • Issue templates
  • Pull request template

Open Pull requests accordingly.

@geektutor
Copy link
Contributor

#13

@paulodiovani
Copy link
Owner Author

There are still a few missing files to have all checks at https://github.com/paulodiovani/hacktoberrank/community. I'll add some suggestions here.


Contributing

👍 🎉 First off, thanks for taking the time to contribute! 🎉 👍

When contributing to this repository, please first discuss the change you wish to make via issue,
email, or any other method with the owners and former collaborators of this repository before making a change.

The Issues section is a good start to check what is needed. Alternatively, you can contribute with small changes, refactoring or improvements that don't have a related issue, in these cases you can just open a pull request.

Please note we have a code of conduct, please follow it in all your interactions with the project.
You can read the code of conduct at https://github.com/paulodiovani/hacktoberrank/blob/master/CODE_OF_CONDUCT.md.

Pull Request Process

  1. Add a description about what the pull request changes or fixes
  2. Ensure the pull request branch can be run following the instructions on README and won't break build and tests in CI.
  3. Write unit tests for new features.
  4. New e2e tests are also welcome but can be written on a separate PR.
  5. Update the README.md with details of changes, if any, including setup/run instructions, interface, etc.
  6. Be kind when discussing changes on pull requests.
  7. Pull Requests are required to be approved at least once to be merged. This process can take a while so be patient.

Other ways of contributing

  • Report bugs or suggest features by writing issues
  • Review and test pull requests by other contributors
  • Spread the word about this project so we can achieve the challenge 🗣️

Pull request template

Detailed changes description...
What this PRs adds or improve in the project.

Is this related to an issue?

Issue #[number] or link.

How to run and see the changes?

  1. Clone this pull request branch
  2. Follow setup instructions on README
  3. Additional steps...

Do we have any screenshots?

screnshot 001

@paulodiovani
Copy link
Owner Author

review and suggestions, please: #24

@paulodiovani paulodiovani added this to the Challenge End milestone Oct 11, 2019
@arabyalhomsi
Copy link
Contributor

Can we have the coverage report tag? the one that says how much code we covered in our tests?

@paulodiovani
Copy link
Owner Author

Can we have the coverage report tag? the one that says how much code we covered in our tests?

Good idea. :)

This was referenced Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants